[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: > tagged as "clang: static analyzer" I think we can. Labeler logic is located there and there is no clang/test/Analysis https://github.com/llvm/llvm-project/blob/main/.github/new-prs-labeler.yml#L496 https://github.com/llvm/llvm-project/pull/126539 __

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag approved this pull request. https://github.com/llvm/llvm-project/pull/126539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: I think we just never cleaned this up. If someone volunteered, I'd be happy to approve the restructuring PR. https://github.com/llvm/llvm-project/pull/126539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > > can we ensure that commits that modify files in clang/test/Analysis > > I believe that directory has tests that are independent of the CSA. :astonished: But why?? Is there any good reason for keeping this mixed test folder, or is this just technical debt from the ancient c

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: > can we ensure that commits that modify files in clang/test/Analysis I believe that directory has tests that are independent of the CSA. So we either have false positives or false negatives or might need to reorganise the test folder a bit. https://github.com/llvm/llvm-proj

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/126539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Donát Nagy via cfe-commits
NagyDonat wrote: **Meta:** can we ensure that commits that modify files in `clang/test/Analysis` (i.e. the static analyzer lit test directory) are tagged as "clang: static analyzer"? I will have a few follow-up commits like this and don't want to spam that label. https://github.com/llvm/llvm-

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) Changes Before commit 6e17ed9b04e5523cc910bf171c3122dcc64b86db the test file `no-outofbounds.c` tested the behavior of the old alpha checker `alpha.security.ArrayBound` (V1); then that commit converted it into a tes

[clang] [NFC][analyzer] OOB test consolidation I: no-outofbounds.c (PR #126539)

2025-02-10 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/126539 Before commit 6e17ed9b04e5523cc910bf171c3122dcc64b86db the test file `no-outofbounds.c` tested the behavior of the old alpha checker `alpha.security.ArrayBound` (V1); then that commit converted it into a test