llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Florian Mayer (fmayer)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/126796.diff
1 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp (+1-1)
``diff
diff --
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/126796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
> I think isa should be preferred if the result of dyncast is not used. Same
> applied to the surrounding ifs too.
https://github.com/llvm/llvm-project/commit/ad905f133c5b22896900f3f335de990d0daf1ff4
https://github.com/llvm/llvm-project/pull/126796
___
steakhal wrote:
Ah, so this one is already merged. Then nvm. It's not worth a followup.
https://github.com/llvm/llvm-project/pull/126796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa commented:
Oh oops, thank you for the fix. It's odd that the checks didn't catch this
before the merge...
https://github.com/llvm/llvm-project/pull/126796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/steakhal commented:
I think isa should be preferred if the result of dyncast is not used.
Same applied to the surrounding ifs too.
https://github.com/llvm/llvm-project/pull/126796
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Florian Mayer (fmayer)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/126796.diff
1 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.cpp (+1-1)
``diff
diff --git a/clang/lib/St
https://github.com/fmayer ready_for_review
https://github.com/llvm/llvm-project/pull/126796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/126796
None
>From 9811b24583640d9d70e5a496d1e3444ee86fea77 Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: Tue, 11 Feb 2025 13:14:26 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=