dklimkin wrote:
Hi AaronBallman, I think I opted to have a minimal change, it was on heap and I
kept it this way. Seems not important for a test only code.
As per NFC, thank you for the note. I considered it NFC as the prod code
behavior didn't change. I'll keep in mind any behavior change cou
AaronBallman wrote:
Thank you for the fix! FWIW, I don't think this is NFC as it is changing test
behavior (fixing a memory leak); please be sure to get a proper code review for
functional changes. The changes are reasonable enough, but one question I have
is: why not stack allocate the object
https://github.com/dklimkin closed
https://github.com/llvm/llvm-project/pull/95927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dklimkin edited
https://github.com/llvm/llvm-project/pull/95927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
