[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From a2393ceb54895e3f6057b649e09732ce3a156811 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From da7ef0a9a45feb9669482040d34a0dd0e2edaa52 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From fe596f4241328f36bda734b2c006aef769efb2c8 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From fb93a08f40800652ebe7065e8495511f9b751ec7 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From b88dcd912f3c9d4c600fa2132dfe84eb74264d10 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 40658e0af6d70dbc1d8cfee026aaa36ef6287276 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

AtariDreams wrote: @rjmccall Done! https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 6c46f5be980dac3200058b694ab7fca3f6ad707e Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

@@ -1,6 +1,12 @@ // RUN: %clang_cc1 -triple x86_64-apple-macosx10.14.0 -emit-llvm %s -o - | FileCheck %s // CHECK: @"OBJC_IVAR_$_StaticLayout.static_layout_ivar" = hidden constant i64 20 +// CHECK: @"OBJC_IVAR_$_SuperClass.superClassIvar" = hidden constant i64 20

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

@@ -17,9 +23,71 @@ @implementation StaticLayout { -(void)meth { static_layout_ivar = 0; // CHECK-NOT: load i64, ptr @"OBJC_IVAR_$_StaticLayout + // CHECK: getelementptr inbounds i8, ptr %0, i64 20 } @end +// Ivars declared in the @interface +@interface SuperClass :

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

@@ -1,6 +1,12 @@ // RUN: %clang_cc1 -triple x86_64-apple-macosx10.14.0 -emit-llvm %s -o - | FileCheck %s // CHECK: @"OBJC_IVAR_$_StaticLayout.static_layout_ivar" = hidden constant i64 20 +// CHECK: @"OBJC_IVAR_$_SuperClass.superClassIvar" = hidden constant i64 20 +// CHECK:

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 570827305ceef6b5e0832fd92faca2b4018a48e0 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From a2514a1b84e43e0868ddbc69296efc7912d9da2f Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 147e27730c9ce5f7baef7363480e98b08190f476 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 147e27730c9ce5f7baef7363480e98b08190f476 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 63f3ada705b69c27ca37207c6f7e8098896602b7 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 63f3ada705b69c27ca37207c6f7e8098896602b7 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From efa382134783898ab2613f13f46dfc3384a3795e Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From efa382134783898ab2613f13f46dfc3384a3795e Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From efa382134783898ab2613f13f46dfc3384a3795e Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/rjmccall commented: Thanks, the breadth of tests looks good. Please improve the actual testing, though — CHECK lines are testing the IR output file at a whole, so now that there are multiple tests in this file, we really need to make these tests more specific. - First,

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

AtariDreams wrote: Ping https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 2cf00f6ddf7be0e51fdb1a27668f3c4c92a8 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 79ffb626e113b74d934b5322eb76f2b97e1dbee5 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 6917791b07ad4fe696e7d5d1e9f378eb0e5ed78d Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 983587c37e18979552ac4ad3891b423c1897a35b Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From af164727a52b49f50a71550326380e16e94e4356 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 1067d095fc6eb955f32c913a9efa42fb1b8e37d0 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From ebaa78d07b5472cac2a1407c2dfb50f4b3f0 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From c6ef77033ad34b7a5b3b1d1a5a89d18d57af0894 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 2e249501668d1c7b18803a922bca7fb473257b0f Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From e586ff3c73dff1f983aa4ec9838c17324e34087d Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

rjmccall wrote: > Alright. I think the LTO should be done as a follow-up PR since it will > likely take some time and multiple reviews to get right. Yes, that's a fine plan. I expect that that'll be a significant amount of work. https://github.com/llvm/llvm-project/pull/81335

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/rjmccall requested changes to this pull request. > @rjmccall Are these tests adequate? No. You need to test the behavior of ivar accesses in the subclass when there is an intermediate superclass that has ivars declared in all the ways I identified. Your test has many

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

AtariDreams wrote: > I talked this over with Mike Ash. I was concerned that Objective-C might > allow dynamic class changes that would burn our ability to do this > optimization, such as adding ivars during `+initialize`. The existing > optimization would work even with a relatively lax

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

rjmccall wrote: I talked this over with Mike Ash. I was concerned that Objective-C might allow dynamic class changes that would burn our ability to do this optimization, such as adding ivars during `+initialize`. The existing optimization would work even with a relatively lax runtime as

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 498111805cc17469522bd5e8f40856b241eac799 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 6103fff6c5040e70fa28bd088f8eafbe479cbab1 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

AaronBallman wrote: > @rjmccall Are these tests adequate? While we appreciate the enthusiasm, please only ping reviewers after about a week of not hearing from them on a review (https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity), thanks!

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 7ef83de2bfc13da0b317d144a38f223b3738889b Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 59c7138d6dce65c22170f4642d0fac6d628c6ad5 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 56207acd7ce55b328b7c72071335b0b452c7a97b Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

AtariDreams wrote: @rjmccall Are these tests adequate? https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 3287e1ddb572f73ca774e50323b037d50b600e34 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 3287e1ddb572f73ca774e50323b037d50b600e34 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits