[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Maybe a clang documentation can be added for this generic offloading > toolchain for OpenMP/CUDA/HIP. Could be a brief description about the > offloading entries and registration mechanism in the beginning then buffy it > up later. We have

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: Maybe a clang documentation can be added for this generic offloading toolchain for OpenMP/CUDA/HIP. Could be a brief description about the offloading entries and registration mechanism in the beginning then buffy it up later. https://github.com/llvm/llvm-project/pull/70116

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/70116 >From 5f8318bcb3419a675680d8e58b4707d42397ae1e Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 24 Oct 2023 15:27:21 -0500 Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,78 @@ +//===- Utility.cpp -- Collection of geneirc offloading utilities --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Matt Arsenault via cfe-commits
arsenm wrote: > to allow for more code re-use in the registeration Typo 'registeration' https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Can this stuff really be generic? Obviously flags are going to be target dependent, but the actual form, generation, and iteration of these can be generic. The idea is to put them all into a single section such that we can filter out the ones that apply to whatever runtime

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread Shilei Tian via cfe-commits
shiltian wrote: Can this stuff really be generic? https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/70116 >From 8add2113864618d310e01bdbb0cf16e1847eb9a8 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 24 Oct 2023 15:27:21 -0500 Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/70116 >From 2af5fc3dc871f0bc3bdfeff4ed2c08f6ccd089d5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 24 Oct 2023 15:27:21 -0500 Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/70116 >From 35347649fe160073e73c3bca96506b6fd96d8a31 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 24 Oct 2023 15:27:21 -0500 Subject: [PATCH] [Offloading][NFC] Move creation of offloading entries from

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c780352de961371949333c3eb0d9d55fda39bf7f 93d72202bc5776483eddb9285ab384979caa85f4 --

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Joseph Huber (jhuber6) Changes Summary: This patch is a first step to remove dependencies on the OpenMPIRBuilder for creating generic offloading entires. This patch changes no functionality and merely moves the code around. In the

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-24 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/70116 Summary: This patch is a first step to remove dependencies on the OpenMPIRBuilder for creating generic offloading entires. This patch changes no functionality and merely moves the code around. In the future the