https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/82814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
> Looks good. Looks like something similar should be done for goto
Thanks! Yes, I agree we probably want to do something similar for goto, but
I'm still looking at it. Trying to keep patches small :)
https://github.com/llvm/llvm-project/pull/82814
https://github.com/alexey-bataev approved this pull request.
Looks good. Looks like something similar should be done for goto
https://github.com/llvm/llvm-project/pull/82814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/82814
>From cdbf2a137ed7ba0a6d40f955072ef636ee93b292 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Fri, 23 Feb 2024 10:36:31 -0800
Subject: [PATCH 1/2] [OpenACC] Implement 'return' branch-out of Compute
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 962a6970f2827bcdda574426701c7c57f79a1ccf
cdbf2a137ed7ba0a6d40f955072ef636ee93b292 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
Like with 'break'/'continue', returning out of a compute construct is
ill-formed, so this implements the diagnostic. However, unlike the OpenMP
implementation of this same diagnostic, OpenACC doesn't
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/82814
Like with 'break'/'continue', returning out of a compute construct is
ill-formed, so this implements the diagnostic. However, unlike the OpenMP
implementation of this same diagnostic, OpenACC doesn't have a