https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/77957
The 'cache' directive and various clauses have a 'tag' name that is optional.
This patch cleans up the use of the 'cache' version so that we get a nicer
diagnostic, and enables us to do the same with clauses
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
The 'cache' directive and various clauses have a 'tag' name that is optional.
This patch cleans up the use of the 'cache' version so that we get a nicer
diagnostic, and enables us to do the same with clau
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e4d01bb2273804355cf84a8a560e578735590ac2
12f5f321bc47bffb2d1694e605288c59976022e6 --
@@ -164,6 +164,49 @@ bool isOpenACCSpecialToken(OpenACCSpecialTokenKind Kind,
Token Tok) {
llvm_unreachable("Unknown 'Kind' Passed");
}
+// Used for cases where we have a token we want to check against an
+// 'identifier-like' token, but don't want to give awkward error mes
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/77957
>From 12f5f321bc47bffb2d1694e605288c59976022e6 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Fri, 12 Jan 2024 09:30:54 -0800
Subject: [PATCH 1/3] [OpenACC} Improve diagnostics for 'tag's on
clauses/directiv
https://github.com/alexey-bataev edited
https://github.com/llvm/llvm-project/pull/77957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alexey-bataev approved this pull request.
LG with a nit
https://github.com/llvm/llvm-project/pull/77957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -164,6 +164,48 @@ bool isOpenACCSpecialToken(OpenACCSpecialTokenKind Kind,
Token Tok) {
llvm_unreachable("Unknown 'Kind' Passed");
}
+// Used for cases where we have a token we want to check against an
+// 'identifier-like' token, but don't want to give awkward error mes
https://github.com/erichkeane updated
https://github.com/llvm/llvm-project/pull/77957
>From 12f5f321bc47bffb2d1694e605288c59976022e6 Mon Sep 17 00:00:00 2001
From: erichkeane
Date: Fri, 12 Jan 2024 09:30:54 -0800
Subject: [PATCH 1/4] [OpenACC} Improve diagnostics for 'tag's on
clauses/directiv
erichkeane wrote:
> LG with a nit
Thanks for the super quick reviews!
https://github.com/llvm/llvm-project/pull/77957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane closed
https://github.com/llvm/llvm-project/pull/77957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
11 matches
Mail list logo
