https://github.com/jplehr created
https://github.com/llvm/llvm-project/pull/75467
This adds a basic test to check the correct generation of double indirect
access to declare target globals in USM mode vs non-USM mode.
I am a bit unhappy with the way this test is set up, but could not find a
be
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Patrick Lehr (jplehr)
Changes
This adds a basic test to check the correct generation of double indirect
access to declare target globals in USM mode vs non-USM mode.
I am a bit unhappy with the way this test is set up, but could not fi
https://github.com/ronlieb approved this pull request.
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jplehr updated
https://github.com/llvm/llvm-project/pull/75467
>From d3d073d7f57f2a5d06cd8c1de8c1503034af3b6b Mon Sep 17 00:00:00 2001
From: JP Lehr
Date: Wed, 12 Jul 2023 05:04:41 -0400
Subject: [PATCH] [OpenMP][USM] Adds test for -fopenmp-force-usm flag
This adds a basic t
jplehr wrote:
Closing this. Test is now part of feature-PR.
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jplehr closed https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jplehr wrote:
The IR is impacted for the global that is in that test case. Lines ~46-50
(first IR section) vs line ~68 (second IR section). The remaining code is
indeed the same.
The way that this test is executed is out of date however, given that I have
reimplemented the flag.
My plan is to
jdoerfert wrote:
I see. FWIW "pGI_decl_tgt_ref_ptr" is really not a good name (not your fault).
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
jplehr wrote:
I updated the feature PR (#75468) with a different solution. Will update the
test after feedback if the route I took in the other PR is seen as OK.
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@
jdoerfert wrote:
How do the IR checks verify the flag works?
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
Test should probably show that IR is equivalent to `#pragma omp requires
unified_shared_memory` or however that's spelled. Basic documentation should be
provided by the help test in the new flag, but we probably have somewhere in
the OpenMP docs you could add it to if desired.
jdoerfert wrote:
I mean, the test shows device IR for two functions, doesn't it? I am not aware
that part is impacted by USM. Host globals/register functions are.
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits
https://github.com/jdoerfert approved this pull request.
https://github.com/llvm/llvm-project/pull/75467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
13 matches
Mail list logo
