https://github.com/alexey-bataev commented:
Need to change the caption and summary of PR, I assume
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/saiislam requested changes to this pull request.
I agree with both points raised by @mjklemm .
Even when we make 6.0 as default, I am pretty sure that many more LIT tests
need to be updated. Please see https://reviews.llvm.org/D129635 for last update
exercise.
We also will
@@ -4174,7 +4174,7 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts,
ArgList &Args,
}
// Check if -fopenmp is specified and set default version to 5.0.
- Opts.OpenMP = Args.hasArg(OPT_fopenmp) ? 51 : 0;
+ Opts.OpenMP = Args.hasArg(OPT_fopenmp) ? 60 : 0;
-
https://github.com/mjklemm edited
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mjklemm edited
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4192,7 +4192,7 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts,
ArgList &Args,
if (Opts.OpenMP || Opts.OpenMPSimd) {
if (int Version = getLastArgIntValue(
Args, OPT_fopenmp_version_EQ,
-(IsSimdSpecified || IsTargetSpecified) ? 51 :
https://github.com/mjklemm requested changes to this pull request.
The PR seems to have two components:
1) Upgrade the compiler code to be able to accept OpenMP 6.0 features
2) switch the default to be OpenMP 6.0
Part 1 is fine, as the community is starting to implement 6.0 features and,
there
alexey-bataev wrote:
> > Not sure this level of support is enough to make 6.0 the default version.
> > We're missing support for some 5.2 features still
>
> That's what I thought! So the macro should continue being set to `202011?
I think yes, unless we support most of the 6.0 features
https:
zahiraam wrote:
> Not sure this level of support is enough to make 6.0 the default version.
> We're missing support for some 5.2 features still
That's what I thought! So the macro should continue being set to `202011?
https://github.com/llvm/llvm-project/pull/122108
___
alexey-bataev wrote:
Not sure this level of support is enough to make 6.0 the default version. We're
missing support for some 5.2 features still
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
zahiraam wrote:
@alexey-bataev Can you please take a look at this draft PR? I think there are
still some LIT tests failing but I want to make sure the changes I am proposing
are correct before making further changes. I am not sure if the macro `_OPENMP`
should be set to `202411` or if it shoul
https://github.com/zahiraam converted_to_draft
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Zahira Ammarguellat (zahiraam)
Changes
In https://github.com/llvm/llvm-project/pull/119891 we are introducing the
support for `#pragma omp stripe` which is an OMP6.0 feature (see
https://github.com/llvm/llvm-project/pull/119891/files#r189
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
16 matches
Mail list logo
