https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/60
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2527,7 +2527,7 @@ class BitsUnpacker {
inline bool shouldSkipCheckingODR(const Decl *D) {
return D->getASTContext().getLangOpts().SkipODRCheckInGMF &&
- D->isFromGlobalModule();
+ (D->isFromGlobalModule() || !D->isInNamedModule());
dmpolu
https://github.com/ChuanqiXu9 approved this pull request.
https://github.com/llvm/llvm-project/pull/60
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/60
>From dc4a79c2ee5630eb551ea3a40b4bd67da20c7034 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 4 Oct 2024 06:41:34 -0700
Subject: [PATCH 1/4] [RFC][C++20][Modules] Relax ODR check in unnamed modules
@@ -2527,7 +2527,7 @@ class BitsUnpacker {
inline bool shouldSkipCheckingODR(const Decl *D) {
return D->getASTContext().getLangOpts().SkipODRCheckInGMF &&
- D->isFromGlobalModule();
+ (D->isFromGlobalModule() || !D->isInNamedModule());
Chuanq
@@ -2527,7 +2527,7 @@ class BitsUnpacker {
inline bool shouldSkipCheckingODR(const Decl *D) {
return D->getASTContext().getLangOpts().SkipODRCheckInGMF &&
- D->isFromGlobalModule();
+ (D->isFromGlobalModule() || !D->isInNamedModule());
Chuanq
@@ -0,0 +1,32 @@
+// RUN: rm -fR %t
+// RUN: split-file %s %t
+// RUN: cd %t
+// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf
-emit-header-unit -xc++-user-header bz0.h
+// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf
-emit-header-unit -xc++-user-heade
@@ -2527,7 +2527,7 @@ class BitsUnpacker {
inline bool shouldSkipCheckingODR(const Decl *D) {
return D->getASTContext().getLangOpts().SkipODRCheckInGMF &&
- D->isFromGlobalModule();
+ (D->isFromGlobalModule() || !D->isInNamedModule());
dmpolu
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/60
>From dc4a79c2ee5630eb551ea3a40b4bd67da20c7034 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 4 Oct 2024 06:41:34 -0700
Subject: [PATCH 1/3] [RFC][C++20][Modules] Relax ODR check in unnamed modules
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/60
>From dc4a79c2ee5630eb551ea3a40b4bd67da20c7034 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 4 Oct 2024 06:41:34 -0700
Subject: [PATCH 1/2] [RFC][C++20][Modules] Relax ODR check in unnamed modules
@@ -2527,7 +2527,7 @@ class BitsUnpacker {
inline bool shouldSkipCheckingODR(const Decl *D) {
return D->getASTContext().getLangOpts().SkipODRCheckInGMF &&
- D->isFromGlobalModule();
+ (D->isFromGlobalModule() || !D->isInNamedModule());
Chuanq
@@ -0,0 +1,32 @@
+// RUN: rm -fR %t
+// RUN: split-file %s %t
+// RUN: cd %t
+// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf
-emit-header-unit -xc++-user-header bz0.h
+// RUN: %clang_cc1 -verify -std=c++20 -fskip-odr-check-in-gmf
-emit-header-unit -xc++-user-heade
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Dmitry Polukhin (dmpolukhin)
Changes
Summary:
Option `-fskip-odr-check-in-gmf` is set by default and I think it is what most
of C++ developers want. But in header units, Clang ODR checking is too strict,
making them hard to use, as seen i
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Dmitry Polukhin (dmpolukhin)
Changes
Summary:
Option `-fskip-odr-check-in-gmf` is set by default and I think it is what most
of C++ developers want. But in header units, Clang ODR checking is too strict,
making them hard to use, a
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/60
Summary:
Option `-fskip-odr-check-in-gmf` is set by default and I think it is what most
of C++ developers want. But in header units, Clang ODR checking is too strict,
making them hard to use, as seen in the
15 matches
Mail list logo
