[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

zeux wrote: Thanks! I've updated this PR with a release note. https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

https://github.com/zeux updated https://github.com/llvm/llvm-project/pull/69126 >From 357a21c38c1036a012affc85026fcba376ab7128 Mon Sep 17 00:00:00 2001 From: Arseny Kapoulkine Date: Sun, 15 Oct 2023 13:20:31 -0700 Subject: [PATCH 1/2] [Sema] -Wzero-as-null-pointer-constant: don't warn for

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

https://github.com/krzysz00 updated https://github.com/llvm/llvm-project/pull/69126 >From 357a21c38c1036a012affc85026fcba376ab7128 Mon Sep 17 00:00:00 2001 From: Arseny Kapoulkine Date: Sun, 15 Oct 2023 13:20:31 -0700 Subject: [PATCH 1/2] [Sema] -Wzero-as-null-pointer-constant: don't warn for

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

https://github.com/AaronBallman commented: I think the changes are reasonable, but should come with a release note so users know about the change in diagnostic behavior. (We have a section in `clang/docs/ReleaseNotes.rst` for diagnostic improvements.) Otherwise, I think the changes LGTM

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

zeux wrote: Ping https://github.com/llvm/llvm-project/pull/69126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

zeux wrote: Note: a limitation of this change is that we will still warn on use of `NULL` when it is defined as 0, which could be a problem for clang-cl. This could be lifted by removing the "NULL" macro name check, but unfortunately that is insufficient to detect the use of NULL inside macro

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Arseny Kapoulkine (zeux) Changes The implementation of -Wzero-as-null-pointer-constant was done before the following fix has been committed to GCC:

[clang] [Sema] -Wzero-as-null-pointer-constant: don't warn for __null (PR #69126)

https://github.com/zeux created https://github.com/llvm/llvm-project/pull/69126 The implementation of -Wzero-as-null-pointer-constant was done before the following fix has been committed to GCC: