erichkeane wrote:
> Thanks. That explains now :)
No problem! Feel free to change a bunch of them, I'm sure we pass by copy
quite a bit, I chased out many of them a while back, but I'm sure i didnt get
them all.
https://github.com/llvm/llvm-project/pull/84459
zyn0217 wrote:
Thanks. That explains now :)
https://github.com/llvm/llvm-project/pull/84459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
Ah, this used to be a really small class, at one point it was an unsigned plus
a handful of array-refs, so it made sense to pass by value. It seems to have
grown a decent bit to the point that pass-by-const-ref now makes sense.
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/84459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/84459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
Changes to `Sema.h` look good to me.
https://github.com/llvm/llvm-project/pull/84459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
We don't modify the MLTAL parameter in `SetupConstraintScope`, and it is better
if we don't copy the 120-byte object each time we call the function.
---
Full diff:
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/84459
We don't modify the MLTAL parameter in `SetupConstraintScope`, and it is better
if we don't copy the 120-byte object each time we call the function.
>From 6d51233690d0030e3191198c1a7a330be723b1af Mon Sep 17
