https://github.com/RKSimon approved this pull request.
LGTM - cheers
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RKSimon wrote:
I meant the patch title - I'm never quite sure how the title/description
appears when these are squashed+merged
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
FreddyLeaf wrote:
> LGTM - please update the description to mention that you're updating the
> movnti i32/i64 scalar integer nt ops as well as the vector ops
I think this description has covered? May display wrong in the preview,
highlighted here:
`For *_stream_* series intrinsics`
https://github.com/FreddyLeaf edited
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf updated
https://github.com/llvm/llvm-project/pull/66310
>From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001
From: Freddy Ye
Date: Thu, 14 Sep 2023 09:17:39 +0800
Subject: [PATCH 1/4] [X86] Align 128/256 variants to use void * as 512
variants.
RKSimon wrote:
They're AMD specific so probably not covered
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
FreddyLeaf wrote:
> For completeness the _mm_stream_sd / _mm_stream_ss SSE4A intrinsics still
> need updating as well:
> https://github.com/llvm/llvm-project/blob/59fbba94908f65eedb8bdd619e425bf97d84b2e3/clang/lib/Headers/ammintrin.h#L158C1-L158C14
Good catch. Seems like intrinsic guide
RKSimon wrote:
For completeness the _mm_stream_sd / _mm_stream_ss SSE4A intrinsics still need
updating as well:
https://github.com/llvm/llvm-project/blob/59fbba94908f65eedb8bdd619e425bf97d84b2e3/clang/lib/Headers/ammintrin.h#L158C1-L158C14
https://github.com/llvm/llvm-project/pull/66310
https://github.com/FreddyLeaf edited
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf updated
https://github.com/llvm/llvm-project/pull/66310
>From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001
From: Freddy Ye
Date: Thu, 14 Sep 2023 09:17:39 +0800
Subject: [PATCH 1/3] [X86] Align 128/256 variants to use void * as 512
variants.
https://github.com/KanRobert approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RKSimon approved this pull request.
LGTM - please update the description to mention that you're updating the movnti
i32/i64 scalar integer nt ops as well as the vector ops
https://github.com/llvm/llvm-project/pull/66310
___
https://github.com/FreddyLeaf resolved
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -358,6 +358,12 @@ __m128i test_mm_stream_load_si128(__m128i const *a) {
return _mm_stream_load_si128(a);
}
+__m128i test_mm_stream_load_si128_void(void const *a) {
FreddyLeaf wrote:
3e463d3c41bb8e8391c62dd95910d009b4b39b7d
https://github.com/FreddyLeaf resolved
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -645,7 +645,7 @@ static __inline__ __m128i __DEFAULT_FN_ATTRS
_mm_mul_epi32(__m128i __V1,
/// \returns A 128-bit integer vector containing the data stored at the
///specified memory location.
static __inline__ __m128i __DEFAULT_FN_ATTRS
-_mm_stream_load_si128(__m128i
https://github.com/FreddyLeaf resolved
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2979,7 +2979,7 @@ _mm256_xor_si256(__m256i __a, __m256i __b)
///A pointer to the 32-byte aligned memory containing the vector to load.
/// \returns A 256-bit integer vector loaded from memory.
static __inline__ __m256i __DEFAULT_FN_ATTRS256
https://github.com/FreddyLeaf resolved
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf edited
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1223,6 +1223,12 @@ __m256i test_mm256_stream_load_si256(__m256i const *a) {
return _mm256_stream_load_si256(a);
}
+__m256i test_mm256_stream_load_si256_const(void const *a) {
FreddyLeaf wrote:
3e463d3
https://github.com/llvm/llvm-project/pull/66310
https://github.com/FreddyLeaf updated
https://github.com/llvm/llvm-project/pull/66310
>From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001
From: Freddy Ye
Date: Thu, 14 Sep 2023 09:17:39 +0800
Subject: [PATCH 1/2] [X86] Align 128/256 variants to use void * as 512
variants.
@@ -1223,6 +1223,12 @@ __m256i test_mm256_stream_load_si256(__m256i const *a) {
return _mm256_stream_load_si256(a);
}
+__m256i test_mm256_stream_load_si256_const(void const *a) {
KanRobert wrote:
+1
https://github.com/llvm/llvm-project/pull/66310
@@ -358,6 +358,12 @@ __m128i test_mm_stream_load_si128(__m128i const *a) {
return _mm_stream_load_si128(a);
}
+__m128i test_mm_stream_load_si128_void(void const *a) {
phoebewang wrote:
`const void`?
https://github.com/llvm/llvm-project/pull/66310
@@ -2979,7 +2979,7 @@ _mm256_xor_si256(__m256i __a, __m256i __b)
///A pointer to the 32-byte aligned memory containing the vector to load.
/// \returns A 256-bit integer vector loaded from memory.
static __inline__ __m256i __DEFAULT_FN_ATTRS256
@@ -645,7 +645,7 @@ static __inline__ __m128i __DEFAULT_FN_ATTRS
_mm_mul_epi32(__m128i __V1,
/// \returns A 128-bit integer vector containing the data stored at the
///specified memory location.
static __inline__ __m128i __DEFAULT_FN_ATTRS
-_mm_stream_load_si128(__m128i
https://github.com/phoebewang edited
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/phoebewang approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf review_requested
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
FreddyLeaf wrote:
Here's the change for 512 variants before: https://reviews.llvm.org/D66786
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
For *_stream_* series intrinsics.
--
Full diff: https://github.com/llvm/llvm-project/pull/66310.diff
10 Files Affected:
- (modified) clang/lib/Headers/avx2intrin.h (+1-1)
- (modified) clang/lib/Headers/avxintrin.h (+3-3)
-
https://github.com/FreddyLeaf review_requested
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf review_requested
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf review_requested
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf review_requested
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf review_requested
https://github.com/llvm/llvm-project/pull/66310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf created
https://github.com/llvm/llvm-project/pull/66310:
For *_stream_* series intrinsics.
>From 21157a0e3b4c4e4e2430752ef806148685a942a2 Mon Sep 17 00:00:00 2001
From: Freddy Ye
Date: Thu, 14 Sep 2023 09:17:39 +0800
Subject: [PATCH] [X86] Align 128/256 variants
40 matches
Mail list logo
