NagyDonat wrote:
In my opinion the "put unrelated things into separate commits" guideline is
just a corollary of the "don't create commits that are too complex" rule. If a
change is extremely trivial, I'm actively trying to aggregate it with other
tangentially related changes, because one simp
Szelethus wrote:
> If these changes are unrelated to each other, wouldn't it be better to
> separate them into 2 commits?
I see the principle, but I think its reasonable to push this one go,
considering that these changes are really minor and inconsquential, especially
since they affect the v
isuckatcs wrote:
If these changes are unrelated to each other, wouldn't it be better to separate
them into 2 commits?
https://github.com/llvm/llvm-project/pull/100570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/NagyDonat closed
https://github.com/llvm/llvm-project/pull/100570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus approved this pull request.
https://github.com/llvm/llvm-project/pull/100570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Donát Nagy (NagyDonat)
Changes
This commit contains two unrelated trivial changes:
(1) Three unused variables are removed from `ctor.mm`.
(2) A FIXME block is removed from `ctor-array.cpp` because it described
an issue that was resolve
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/100570
This commit contains two unrelated trivial changes:
(1) Three unused variables are removed from `ctor.mm`.
(2) A FIXME block is removed from `ctor-array.cpp` because it described
an issue that was resolved
