https://github.com/spaits created
https://github.com/llvm/llvm-project/pull/76501
Add a short documentation for `StdVariantChecker`.
From f7f26c38d1d363bf1dd097dc73e004970dfb32df Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH] [analyzer] Add d
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Gábor Spaits (spaits)
Changes
Add a short documentation for `StdVariantChecker`.
---
Full diff: https://github.com/llvm/llvm-project/pull/76501.diff
1 Files Affected:
- (modified) clang/docs/analyzer/checkers.rst (+12)
``diff
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From e885006a873e4bd8eb4618c270bac72c11446f06 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH] [analyzer] Add documentation for std::variant checker
---
clang/do
https://github.com/DonatNagyE requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DonatNagyE edited
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2097,6 +2097,18 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if the active value accessed in an ``std::variant`` instance.
---
@@ -2097,6 +2097,18 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if the active value accessed in an ``std::variant`` instance.
+.. code-bl
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From e885006a873e4bd8eb4618c270bac72c11446f06 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH 1/2] [analyzer] Add documentation for std::variant checker
---
clan
DonatNagyE wrote:
Note: the docs build check failed with
> /home/runner/work/llvm-project/llvm-project/clang-build/tools/clang/docs/analyzer/checkers.rst:2108:Definition
> list ends without a blank line; unexpected unindent.
https://github.com/llvm/llvm-project/pull/76501
__
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From c1884cc4d17c446491777baa43e3996aae22ad0d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH] [analyzer] Add documentation for std::variant checker
---
clang/do
https://github.com/DonatNagyE edited
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DonatNagyE commented:
There is a trivial typo, otherwise LGTM.
Thanks for the update!
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -2097,6 +2097,21 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if a value of active type is retrieved from an ``std::variant`` instance
spaits wrote:
Added some more explanation. I will continue using "Check if" since the other
descriptions that I saw stared like that (or "Check for").
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From c1884cc4d17c446491777baa43e3996aae22ad0d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH 1/2] [analyzer] Add documentation for std::variant checker
---
clan
https://github.com/steakhal commented:
Please also update the release notes with a link as documentation. Follow the
existing patterns there.
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
DonatNagyE wrote:
> Added some more explanation. I will continue using "Check if" since the other
> descriptions that I saw stared like that (or "Check for").
That's a good point for using "Check if".
https://github.com/llvm/llvm-project/pull/76501
_
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2097,6 +2097,21 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if a value of active type is retrieved from an ``std::variant`` instance
https://github.com/steakhal requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2097,6 +2097,18 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if the active value accessed in an ``std::variant`` instance.
+.. code-bl
@@ -2097,6 +2097,21 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if a value of active type is retrieved from an ``std::variant`` instance
@@ -2097,6 +2097,21 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if a value of active type is retrieved from an ``std::variant`` instance
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From 682bed6d800133a2d1f21bd49491d002ec8c6b54 Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH] [analyzer] Add documentation for std::variant checker
---
clang/do
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From e0dabac5d84c291da39646efda189f6cdbcc369b Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH] [analyzer] Add documentation for std::variant checker
---
clang/do
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From daec81389ccaa23f6f8c75abac9a2f827d4c0fcd Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH] [analyzer] Add documentation for std::variant checker
---
clang/do
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From b271420a6e4ed23abf2749d767f986aa16d9fe9d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH] [analyzer] Add documentation for std::variant checker
---
clang/do
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From b271420a6e4ed23abf2749d767f986aa16d9fe9d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH 1/2] [analyzer] Add documentation for std::variant checker
---
clan
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From b271420a6e4ed23abf2749d767f986aa16d9fe9d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH 1/3] [analyzer] Add documentation for std::variant checker
---
clan
=?utf-8?q?Gábor?= Spaits
Message-ID:
In-Reply-To:
@@ -2097,6 +2097,21 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
.. _alpha-core-TestAfterDivZero:
+alpha.core.StdVariant (C++)
+"""
+Check if a value of active
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From b271420a6e4ed23abf2749d767f986aa16d9fe9d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH 1/4] [analyzer] Add documentation for std::variant checker
---
clan
https://github.com/spaits updated
https://github.com/llvm/llvm-project/pull/76501
From b271420a6e4ed23abf2749d767f986aa16d9fe9d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Date: Thu, 28 Dec 2023 14:17:55 +0100
Subject: [PATCH 1/5] [analyzer] Add documentation for std::variant checker
---
clan
=?utf-8?q?G=C3=A1bor?= Spaits,=?utf-8?q?G=C3=A1bor?= Spaits,
=?utf-8?q?G=C3=A1bor?= Spaits
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE approved this pull request.
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
=?utf-8?q?G=C3=A1bor?= Spaits,=?utf-8?q?G=C3=A1bor?= Spaits,
=?utf-8?q?G=C3=A1bor?= Spaits
Message-ID:
In-Reply-To:
steakhal wrote:
let me check it again
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.l
=?utf-8?q?Gábor?= Spaits,=?utf-8?q?Gábor?= Spaits,
=?utf-8?q?Gábor?= Spaits,Balazs Benics
Message-ID:
In-Reply-To:
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/76501
>From b271420a6e4ed23abf2749d767f986aa16d9fe9d Mon Sep 17 00:00:00 2001
From: Gabor Spaits
Da
=?utf-8?q?G=C3=A1bor?= Spaits,=?utf-8?q?G=C3=A1bor?= Spaits,
=?utf-8?q?G=C3=A1bor?= Spaits,Balazs Benics
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
LGTM now. Thanks.
https://github.com/llvm/llvm-project/pull/76501
_
spaits wrote:
I will merge the PR when the CI builds have finished. Thank you for reviewing.
https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/76501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
38 matches
Mail list logo
