DonatNagyE wrote:
This commit accidentally left behind two unused functions; thanks
@kazutakahirata for quickly fixing my mistake!
https://github.com/llvm/llvm-project/pull/66647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/DonatNagyE closed
https://github.com/llvm/llvm-project/pull/66647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
Should be good. Feel free to merge this.
Sorry for it taking so long.
https://github.com/llvm/llvm-project/pull/66647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
vabridgers wrote:
LGTM if ok with everyone.
https://github.com/llvm/llvm-project/pull/66647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DonatNagyE wrote:
Sorry for the inaccessible reports, I forgot to specify that the results should
go to the server that we use for open-source reviews.
I'd like to skip the conversion of the testcases that I deleted, because there
won't be folks "wondering what happened with these reports": In
steakhal wrote:
I think I'm fine with the numbers. Note that I could not inspect individual
reports because the URL likely refers to some internal server on your side.
Anyway, I'd recommend keeping the test files for two reasons:
- It's probably not a big deal, we are talking about ~150 lines
DonatNagyE wrote:
The impact is limited, because `core.BitwiseShift` is a `PreStmt` callback, so
when I merged it, it turned the logic tweaked/affected in this commit into
"almost dead" code.
The most significant change is that some "pedantic-only" issues (i.e. code like
`-1 >> 3` that's unde
steakhal wrote:
What report diff's should we expect?
https://github.com/llvm/llvm-project/pull/66647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Changes
Previously, bitwise shifts with constant operands were validated by the checker
`core.UndefinedBinaryOperatorResult`. However, this logic was unreliable, and
commit 25b9696b61e53a958e217bb3d0eab66350dc187f added the dedic
https://github.com/DonatNagyE created
https://github.com/llvm/llvm-project/pull/66647
Previously, bitwise shifts with constant operands were validated by the checker
`core.UndefinedBinaryOperatorResult`. However, this logic was unreliable, and
commit 25b9696b61e53a958e217bb3d0eab66350dc187f ad
10 matches
Mail list logo
