https://github.com/haoNoQ closed https://github.com/llvm/llvm-project/pull/79398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ created
https://github.com/llvm/llvm-project/pull/79398
There are currently a few checkers that don't fill in the bug report's
"decl-with-issue" field (typically a function in which the bug is found).
The new attribute `[[clang::suppress]]` uses decl-with-issue to red
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Artem Dergachev (haoNoQ)
Changes
There are currently a few checkers that don't fill in the bug report's
"decl-with-issue" field (typically a function in which the bug is found).
The new attribute `[[clang::suppress]]` uses decl-with-issue
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Artem Dergachev (haoNoQ)
Changes
There are currently a few checkers that don't fill in the bug report's
"decl-with-issue" field (typically a function in which the bug is found).
The new attribute `[[clang::suppress]]` us
https://github.com/haoNoQ unassigned
https://github.com/llvm/llvm-project/pull/79398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a58dcc5e08665f2d58a28c9d4510cf94de6ed3bf
21923f92f0ea4169d5fea646221554d4c44e36f1 --
haoNoQ wrote:
The affected checkers were:
- Checkers in the `webkit` package (hence cc @jkorous-apple). These checkers
manually scan the entire TU in order (rejecting the comforts of
`checkASTCodeBody`) in order to properly cover uninstantiated templates.
There's no reason they can't provide a
https://github.com/haoNoQ updated
https://github.com/llvm/llvm-project/pull/79398
>From 21923f92f0ea4169d5fea646221554d4c44e36f1 Mon Sep 17 00:00:00 2001
From: Artem Dergachev
Date: Wed, 24 Jan 2024 14:52:58 -0800
Subject: [PATCH 1/2] [analyzer] Unbreak [[clang::suppress]] on checkers
without
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/79398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal commented:
I only have minor nits. No objections.
https://github.com/llvm/llvm-project/pull/79398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -27,6 +28,8 @@ class PathDiagnosticLocation;
class BugSuppression {
public:
+ BugSuppression(ASTContext &ACtx) : ACtx(ACtx) {}
steakhal wrote:
```suggestion
explicit BugSuppression(const ASTContext &ACtx) : ACtx(ACtx) {}
```
https://github.com/llvm/llv
@@ -44,7 +47,9 @@ class BugSuppression {
using CachedRanges =
llvm::SmallVector;
- llvm::DenseMap CachedSuppressionLocations;
+ llvm::DenseMap CachedSuppressionLocations{};
+
+ ASTContext &ACtx;
steakhal wrote:
```suggestion
llvm::DenseMap Cached
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/79398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jkorous-apple approved this pull request.
Thanks for fixing this!
LGTM from the perspective of WebKit checkers.
https://github.com/llvm/llvm-project/pull/79398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -27,6 +28,8 @@ class PathDiagnosticLocation;
class BugSuppression {
public:
+ BugSuppression(ASTContext &ACtx) : ACtx(ACtx) {}
haoNoQ wrote:
Hmm I somehow never noticed that we have any actual const-correctness for
`ASTContext`, thanks!
https://github.c
https://github.com/haoNoQ updated
https://github.com/llvm/llvm-project/pull/79398
>From 21923f92f0ea4169d5fea646221554d4c44e36f1 Mon Sep 17 00:00:00 2001
From: Artem Dergachev
Date: Wed, 24 Jan 2024 14:52:58 -0800
Subject: [PATCH 1/3] [analyzer] Unbreak [[clang::suppress]] on checkers
without
https://github.com/haoNoQ updated
https://github.com/llvm/llvm-project/pull/79398
>From 21923f92f0ea4169d5fea646221554d4c44e36f1 Mon Sep 17 00:00:00 2001
From: Artem Dergachev
Date: Wed, 24 Jan 2024 14:52:58 -0800
Subject: [PATCH 1/4] [analyzer] Unbreak [[clang::suppress]] on checkers
without
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/79398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ updated
https://github.com/llvm/llvm-project/pull/79398
>From 21923f92f0ea4169d5fea646221554d4c44e36f1 Mon Sep 17 00:00:00 2001
From: Artem Dergachev
Date: Wed, 24 Jan 2024 14:52:58 -0800
Subject: [PATCH 1/5] [analyzer] Unbreak [[clang::suppress]] on checkers
without
19 matches
Mail list logo
