kpdev wrote:
> LGTM, do you need someone to land this on your behalf?
Thank you, Aaron. Commit landed
https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/kpdev closed https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, do you need someone to land this on your behalf?
https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/78253
>From ebe0b998fc0476aed38fff7fcf368a08ddbda8a3 Mon Sep 17 00:00:00 2001
From: Nikolai Kholiavin
Date: Wed, 20 Dec 2023 16:19:03 +
Subject: [PATCH] [cfi][CodeGen] Call SetLLVMFunctionAttributes{,ForDefinition}
kpdev wrote:
> Should we add a release note to `clang/docs/ReleaseNotes.rst` so users know
> about the changes?
Seems reasonable ) Should I add it somewhere to
[`Sanitizers`](https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst#sanitizers)
?
@@ -3443,11 +3443,28 @@ void CodeGenFunction::EmitCfiSlowPathCheck(
void CodeGenFunction::EmitCfiCheckStub() {
llvm::Module *M = ();
auto = M->getContext();
+ auto = getContext();
kpdev wrote:
Changed, please review
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/78253
>From 9850957ff41dd5cbe72fd76925a32ad9c277d5e1 Mon Sep 17 00:00:00 2001
From: Nikolai Kholiavin
Date: Wed, 20 Dec 2023 16:19:03 +
Subject: [PATCH] [cfi][CodeGen] Call SetLLVMFunctionAttributes{,ForDefinition}
https://github.com/rjmccall approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3443,11 +3443,28 @@ void CodeGenFunction::EmitCfiSlowPathCheck(
void CodeGenFunction::EmitCfiCheckStub() {
llvm::Module *M = ();
auto = M->getContext();
+ auto = getContext();
AaronBallman wrote:
Please spell out the types here instead of using
https://github.com/AaronBallman commented:
I think the code looks pretty reasonable, but I've added codegen code owners
for final sign-off. Should we add a release note to
`clang/docs/ReleaseNotes.rst` so users know about the changes?
https://github.com/llvm/llvm-project/pull/78253
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kpdev wrote:
@AaronBallman @kongy Hi! Could you please take a look at this patch?
https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kpdev wrote:
Ping
https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kpdev wrote:
The same thing was done for `__cfi_check_fail` in the following patch:
https://reviews.llvm.org/D70692
https://github.com/llvm/llvm-project/pull/78253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Pavel Kosov (kpdev)
Changes
…i_check
This causes __cfi_check, just as __cfi_check_fail, to get the proper
target-specific attributes, in particular uwtable for unwind table generation.
Previously, nounwind attribute could be inferred
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Pavel Kosov (kpdev)
Changes
…i_check
This causes __cfi_check, just as __cfi_check_fail, to get the proper
target-specific attributes, in particular uwtable for unwind table generation.
Previously, nounwind attribute could be
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/78253
…i_check
This causes __cfi_check, just as __cfi_check_fail, to get the proper
target-specific attributes, in particular uwtable for unwind table generation.
Previously, nounwind attribute could be inferred for
17 matches
Mail list logo
