[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-08-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/100355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-08-08 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100355 >From 2b1255de05856e4c79f58d3e4071384ba80a881d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 18 Jul 2024 16:26:16 -0500 Subject: [PATCH 1/3] [clang][Sema] Don't mark VarDecls of bindings in tuple-li

[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-08-06 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl approved this pull request. So this patch makes structured bindings not artificial, so they aren't hidden in debuggers by default. That sounds right to me. https://github.com/llvm/llvm-project/pull/100355 ___ cfe-commi

[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-07-31 Thread Michael Buch via cfe-commits
Michael137 wrote: ping https://github.com/llvm/llvm-project/pull/100355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-07-24 Thread Michael Buch via cfe-commits
Michael137 wrote: > It looks like this is working for all other kinds of structured binding > because `EmitDeclare(BindingDecl*, ...)` emits a proper `DILocalVariable` for > them. But it skips `BindingDecl`s that have a holding variable for some > reason. Perhaps a cleaner approach would be to

[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-07-24 Thread Richard Smith via cfe-commits
zygoloid wrote: It looks like this is working for all other kinds of structured binding because `EmitDeclare(BindingDecl*, ...)` emits a proper `DILocalVariable` for them. But it skips `BindingDecl`s that have a holding variable for some reason. Perhaps a cleaner approach would be to make it h

[clang] [clang][DebugInfo] Don't mark structured bindings as artificial (PR #100355)

2024-07-24 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/100355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits