[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/74790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

https://github.com/efriedma-quic updated https://github.com/llvm/llvm-project/pull/74790 >From 476402a90cc24a5697efbef0b3bcb1276a4bc6f5 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 7 Dec 2023 16:21:53 -0800 Subject: [PATCH] [clang][Driver] Support -fms-volatile as equivalent to

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/74790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

@@ -611,3 +611,9 @@ // CHECK-INT-OBJEMITTER-NOT: unsupported option '-fintegrated-objemitter' for target // RUN: not %clang -### -fno-integrated-objemitter --target=x86_64 %s 2>&1 | FileCheck -check-prefix=CHECK-NOINT-OBJEMITTER %s // CHECK-NOINT-OBJEMITTER: unsupported

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/74790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

https://github.com/rnk approved this pull request. > And it's a pretty straightforward extension to support (it just slightly > modifies IR generation), so I don't think there's much long-term support > burden. I find that compelling, but make sure others' concerns are addressed.

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

efriedma-quic wrote: I got a request for this feature from a user that ran into issues porting code from cl to clang for a baremetal target. I expect scenarios like that to continue to be relevant for a while. I don't expect anyone would want to use this for new code because current

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

https://github.com/rnk commented: > I assume that /volatile:ms is a legacy behavior that non-Windows OSes likely > don't want to adopt. That is correct, it is legacy behavior. However, I think this flag has potential porting applications, similar to `-fshort-wchar`. I also think operating

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

MaskRay wrote: Current behavior: ``` % clang --target=x86_64-linux-musl -fms-volatile -c a.cc clang: warning: argument unused during compilation: '-fms-volatile' [-Wunused-command-line-argument] % clang --target=x86_64-windows -fms-volatile -c a.cc clang: warning: argument unused during

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Eli Friedman (efriedma-quic) Changes The flag -fms-volatile has existed as a -cc1 flag for a while. It also technically existed as a driver flag, but didn't do anything because it wasn't wired up to anything in the driver. This

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Eli Friedman (efriedma-quic) Changes The flag -fms-volatile has existed as a -cc1 flag for a while. It also technically existed as a driver flag, but didn't do anything because it wasn't wired up to anything in the driver. This patch

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/74790 The flag -fms-volatile has existed as a -cc1 flag for a while. It also technically existed as a driver flag, but didn't do anything because it wasn't wired up to anything in the driver. This patch adds