https://github.com/isuckatcs closed
https://github.com/llvm/llvm-project/pull/68246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
isuckatcs wrote:
>it could come in handy in the future
For me it was helpful to check what is on the stack at the moment, so it's
definitely handy I think.
https://github.com/llvm/llvm-project/pull/68246
___
cfe-commits mailing list
https://github.com/tbaederr approved this pull request.
https://github.com/llvm/llvm-project/pull/68246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
> Although the previous
> implementation didn't have unittests either, so I'm not sure if we actually
> care that much or not.
We don't, I think I've used this function once. But I don't want to delete it
either because it could come in handy in the future.
LGTM
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
`InterpStack` is using an `std::vector` to track the `ItemTypes`. As a
result, the new types are inserted
to the back of the `std::vector`, however `dump()` was reading the
types from the front (the bottom
of the stack) and printing the
https://github.com/isuckatcs created
https://github.com/llvm/llvm-project/pull/68246
`InterpStack` is using an `std::vector<>` to track the `ItemTypes`. As a
result, the new types are inserted
to the back of the `std::vector<>`, however `dump()` was reading the types from
the front (the
