https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70772
>From 8449070d0cec2ad120c9d8a36a72594d595b7fea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 07:17:16 +0100
Subject: [PATCH] [clang][Interp] Handle std::move etc. builtins
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70772
>From 7f4cb1f727a497c6da1fc3f4740522ff5adb3964 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 07:17:16 +0100
Subject: [PATCH] [clang][Interp] Handle std::move etc. builtins
@@ -378,3 +378,92 @@ namespace Packs {
static_assert(foo() == 2, "");
static_assert(foo<>() == 0, "");
}
+
+namespace std {
+template struct remove_reference { using type = T; };
+template struct remove_reference { using type = T; };
+template struct remove_reference { u
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70772
>From c6c7d246b334a95306cda410e7d115353acb7c5e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 07:17:16 +0100
Subject: [PATCH] [clang][Interp] Handle std::move etc. builtins
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70772
>From e850b96306ab5d9e6aac4171150195ea013f6ec2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
https://github.com/AaronBallman approved this pull request.
LGTM assuming no surprises come up from the additional test coverage.
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits ma
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
@@ -378,3 +378,92 @@ namespace Packs {
static_assert(foo() == 2, "");
static_assert(foo<>() == 0, "");
}
+
+namespace std {
+template struct remove_reference { using type = T; };
+template struct remove_reference { using
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70772
>From 5436d89e4ca3fbb1d53f27f8d5347f3eff100dd3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 07:17:16 +0100
Subject: [PATC
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
hnrklssn wrote:
LGTM, but someone else should approve also.
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/70772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
tbaederr wrote:
> Nice. I realise you're following the convention already established in the
> test file, but have you considered compiling with `-verify=new,both` and
> `-verify=ref,both`, respectively, and combining the shared diagnostics int
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
hnrklssn wrote:
Nice. I realise you're following the convention already established in the test
file, but have you considered compiling with `-verify=new,both` and
`-verify=ref,both`, respectively, and combining the shared diagnostics into
`bo
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/70772
>From b670986c19e412b3c140b610f2c26d957544b23a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 07:17:16 +0100
Subject: [PATC
hnrklssn wrote:
Would making a class with custom move and copy constructors with side effects,
and moving/copying an instance around a bit to affect the results of
static_asserts, work for testing?
https://github.com/llvm/llvm-project/pull/70772
___
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Only light testing here since I'm not sure how to properly test this.
---
Full diff: https://github.com/llvm/llvm-project/pull/70772.diff
2 Files Affected:
- (modified) clang/lib/AST/Interp/InterpBuiltin.c
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/70772
Only light testing here since I'm not sure how to properly test this.
>From b670986c19e412b3c140b610f2c26d957544b23a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 07:17:16
21 matches
Mail list logo