https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/68679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/68679
>From 8aae860a7079d50e8b3a657335e115c2cca9fcc1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 10 Oct 2023 08:52:43 +0200
Subject: [PATCH] [clang][Interp] Support AddOffset with 128bit
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/68679
>From 9598f33926ede7a35a431bebc3ed6f8ce20b03ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 10 Oct 2023 08:52:43 +0200
Subject: [PATCH] [clang][Interp] Support AddOffset with 128bit
https://github.com/AaronBallman approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/68679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/68679
>From 5fff64e74c885472abcd2a320d6db9005cc7c4fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 10 Oct 2023 08:52:43 +0200
Subject: [PATCH] [clang][Interp] Support AddOffset with 128bit
https://github.com/tbaederr edited
https://github.com/llvm/llvm-project/pull/68679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1437,7 +1437,7 @@ bool OffsetHelper(InterpState , CodePtr OpPC, const T
,
return false;
};
- unsigned MaxOffset = MaxIndex - Ptr.getIndex();
+ T MaxOffset = T::from(MaxIndex - Ptr.getIndex(), Offset.bitWidth());
AaronBallman wrote:
I think we
@@ -1437,7 +1437,7 @@ bool OffsetHelper(InterpState , CodePtr OpPC, const T
,
return false;
};
- unsigned MaxOffset = MaxIndex - Ptr.getIndex();
+ T MaxOffset = T::from(MaxIndex - Ptr.getIndex(), Offset.bitWidth());
tbaederr wrote:
Dunno, We never
@@ -1437,7 +1437,7 @@ bool OffsetHelper(InterpState , CodePtr OpPC, const T
,
return false;
};
- unsigned MaxOffset = MaxIndex - Ptr.getIndex();
+ T MaxOffset = T::from(MaxIndex - Ptr.getIndex(), Offset.bitWidth());
erichkeane wrote:
Should MaxIndex
https://github.com/tbaederr edited
https://github.com/llvm/llvm-project/pull/68679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
We do a similar things a few lines above for `Index`:
```
// Get a version of the index comparable to the type.
T Index = T::from(Ptr.getIndex(), Offset.bitWidth());
```
---
Full diff:
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/68679
We do a similar things a few lines above for `Index`:
```
// Get a version of the index comparable to the type.
T Index = T::from(Ptr.getIndex(), Offset.bitWidth());
```
>From
12 matches
Mail list logo