[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-20 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/85623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-19 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. https://github.com/llvm/llvm-project/pull/85623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: > I've moved the documentation down, right above the declaration of `path()`. > WDYT? I think that should work. https://github.com/llvm/llvm-project/pull/85623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-19 Thread via cfe-commits
martinboehme wrote: > Does this actually show up at the right place? Or is it now the documentation > for `path_empty()`? Or even `path_iterator`? Hm, good question. This seemed the most logical place to put the documentation in the source code, but of course, once it gets processed by

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-19 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/85623 >From 369410916bd61671f81702c4654bd48bfc3c6c53 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Mon, 18 Mar 2024 09:51:23 + Subject: [PATCH 1/3] [clang][NFC] Add documentation for `CastExpr::path()`.

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-19 Thread Timm Baeder via cfe-commits
tbaederr wrote: Does this actually show up at the right place? Or is it now the documentation for `path_empty()`? Or even `path_iterator`? https://github.com/llvm/llvm-project/pull/85623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-19 Thread via cfe-commits
@@ -3552,6 +3552,15 @@ class CastExpr : public Expr { /// function that it invokes. NamedDecl *getConversionFunction() const; + /// Path through the class hierarchy taken by a `DerivedToBase` or + /// `UncheckedDerivedToBase` cast. For each derived-to-base edge in the

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-19 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/85623 >From 369410916bd61671f81702c4654bd48bfc3c6c53 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Mon, 18 Mar 2024 09:51:23 + Subject: [PATCH 1/2] [clang][NFC] Add documentation for `CastExpr::path()`.

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-18 Thread John McCall via cfe-commits
@@ -3552,6 +3552,15 @@ class CastExpr : public Expr { /// function that it invokes. NamedDecl *getConversionFunction() const; + /// Path through the class hierarchy taken by a `DerivedToBase` or + /// `UncheckedDerivedToBase` cast. For each derived-to-base edge in the

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/85623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-18 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/85623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes This didn't have any documentation, so I had to do some experimenting in godbolt when I used this in https://github.com/llvm/llvm-project/pull/84138, and my reviewer later also had some

[clang] [clang][NFC] Add documentation for `CastExpr::path()`. (PR #85623)

2024-03-18 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/85623 This didn't have any documentation, so I had to do some experimenting in godbolt when I used this in https://github.com/llvm/llvm-project/pull/84138, and my reviewer later also had some