[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/82919 clang-format would format these headers poorly by splitting it into multiple lines. ```regex //=.{78,} ``` >From 319329630e0d2a86b22dd435985026ea236f8e56 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Sun

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes clang-format would format these headers poorly by splitting it into multiple lines. ```regex //=.{78,} ``` --- Patch is 25.48 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llv

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

https://github.com/NagyDonat approved this pull request. https://github.com/llvm/llvm-project/pull/82919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

@@ -1,10 +1,10 @@ -//===- unittest/ASTMatchers/Dynamic/VariantValueTest.cpp - VariantValue unit tests -===// +// unittest/ASTMatchers/Dynamic/VariantValueTest.cpp - VariantValue unit tests pogo59 wrote: Repeating the full path name seems unnecessary? (In various

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

dwblaikie wrote: +1 to @pogo59's comment about pruning complete paths - I suspect they're in the minority. Might be worth checking whether the `===` at the start and end is markup for any particular thing (I /think/ the `-*- C++ -*-` is load bearing for some editors to inform them this `.h` fi

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

steakhal wrote: > +1 to @pogo59's comment about pruning complete paths - I suspect they're in > the minority. Might be worth checking whether the `===` at the start and end > is markup for any particular thing (I /think/ the `-*- C++ -*-` is load > bearing for some editors to inform them this

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

steakhal wrote: I did some grepping. Inside the `clang` project: `^/+=(.*)/(.*)...$`: 297 files `^/+=([^\n/]*)\.(h|cpp)([^\n/]*)...$`: 1766 files This suggests to me that indeed, absolute paths are the used way fewer times. https://github.com/llvm/llvm-project/pull/82919 ___

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

pogo59 wrote: I grepped `clang` for "^/+=[^/]*/.*\.(h|cpp) " and found only 35 files with directory components. So, the majority of files have only the filename in the header line. The example in the Coding Standard does not reflect common practice. I think it's fine to remove everything but

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/82919 >From 319329630e0d2a86b22dd435985026ea236f8e56 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Sun, 25 Feb 2024 12:48:06 +0100 Subject: [PATCH 1/2] [clang][NFC] Trim license header comments to 81 characters

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

@@ -1,10 +1,10 @@ -//===- unittest/ASTMatchers/Dynamic/VariantValueTest.cpp - VariantValue unit tests -===// +// unittest/ASTMatchers/Dynamic/VariantValueTest.cpp - VariantValue unit tests steakhal wrote: Fixed. https://github.com/llvm/llvm-project/pull/82919 _

[clang] [clang][NFC] Trim license header comments to 81 characters (PR #82919)

https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/82919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits