https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/128038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/128038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -408,7 +408,9 @@ class Context {
unsigned getRequiredVectorWidth(unsigned ID) const;
- /// Return true if builtin ID belongs to AuxTarget.
+ /// Return true if builtin ID belongs to only the AuxTarget.
sarnex wrote:
sure, applied this in latest commit
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/128038
>From e866ecff509662fd1f9942fb415291d43e20ee31 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Thu, 20 Feb 2025 09:52:35 -0800
Subject: [PATCH 1/2] [clang][NFC] Update isAuxBuiltinID comment
Signed-off-by: S
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/128038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -408,7 +408,9 @@ class Context {
unsigned getRequiredVectorWidth(unsigned ID) const;
- /// Return true if builtin ID belongs to AuxTarget.
+ /// Return true if builtin ID belongs to only the AuxTarget.
erichkeane wrote:
Perhaps, "Return true if the bu
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nick Sarnie (sarnex)
Changes
Clarify behavior of the function when the builtin is also supported on the main
target.
Based on feedback from https://github.com/llvm/llvm-project/pull/126324
---
Full diff: https://github.com/llvm/llvm-proje
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/128038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/128038
None
>From e866ecff509662fd1f9942fb415291d43e20ee31 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Thu, 20 Feb 2025 09:52:35 -0800
Subject: [PATCH] [clang][NFC] Update isAuxBuiltinID comment
Signed-off-by: