[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-27 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Will revisit this when the using code is ready for review/merge. https://github.com/llvm/llvm-project/pull/8 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-27 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/8 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > > Are you going to submit your code? > > Yes, but it's still incomplete. I can wait with this PR if you prefer. Yes, I think better to introduce it with the actual user. https://github.com/llvm/llvm-project/pull/8 ___ cfe-c

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Are you going to submit your code? Yes, but it's still incomplete. I can wait with this PR if you prefer. https://github.com/llvm/llvm-project/pull/8 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > I don't think so, because nothing is failing without it. This is just for > completeness. > > Edit: My code will use it, but at the moment there aren't any users that I > know of. Are you going to submit your code? https://github.com/llvm/llvm-project/pull/8 __

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I don't think so, because nothing is failing without it. This is just for completeness. https://github.com/llvm/llvm-project/pull/8 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: This brings a question: most of such accessors return `Expr *` in both const and non-const versions. If that's intended, does it make sense to even have non-const variants of these accessors? https://github.com/llvm/llvm-project/pull/8 _

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Do we have a user for this function? https://github.com/llvm/llvm-project/pull/8 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes NFC --- Full diff: https://github.com/llvm/llvm-project/pull/8.diff 1 Files Affected: - (modified) clang/include/clang/AST/OpenMPClause.h (+5) ``diff diff --git a/clang/include/clang

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-26 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/8 NFC >From 3ffabe11eb01f42ceaeb92895a0eb0f251e6ef9a Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 21 Mar 2024 06:54:02 -0500 Subject: [PATCH] [clang][OpenMP] Add const-qualified `getIteratorModif