[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

https://github.com/JOE1994 closed https://github.com/llvm/llvm-project/pull/90625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/90625 >From 0a1598d0e00cbbfd0320ea72491500957ddb6b52 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Tue, 30 Apr 2024 11:18:15 -0500 Subject: [PATCH 1/2] [clang][Sema] Re-use existing BinaryOperator if possible

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

https://github.com/erichkeane commented: This seems reasonable to me. We need a release note however. https://github.com/llvm/llvm-project/pull/90625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/90625 >From 0a1598d0e00cbbfd0320ea72491500957ddb6b52 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Tue, 30 Apr 2024 11:18:15 -0500 Subject: [PATCH] [clang][Sema] Re-use existing BinaryOperator if possible First

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

JOE1994 wrote: Buildkite passed on Linux x64 but failed on Windows x64 . Test log doesn't show any test failures except for `XFAIL` runs, so I'm not sure what's causing the failure. Will rebase onto latest `main` to try the build again. https://github.com/llvm/llvm-project/pull/90625

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/90625 >From 3b2f810ff3798ef073a8d1a10ca6fbafdbdb4641 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Tue, 30 Apr 2024 11:18:15 -0500 Subject: [PATCH] [clang][Sema] Re-use existing BinaryOperator if possible First

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

JOE1994 wrote: `clang-format` issues an error for the comments from a previous commit wrote by a different author. I'd like to disregard the clang-format errror, so to keep the diff of this commit minimial. https://github.com/llvm/llvm-project/pull/90625

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 97069a86193a617a9e4cf742a29db6116b2bf449 24eb4db70e296d6454bac4c84a5bbc47e638876f --

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Youngsuk Kim (JOE1994) Changes First round of Sema checks were run at initial parsing step. Creating a new BinaryOperator instance (with the re-built LHS or RHS) will trigger another round of Sema checks, which can lead to duplicate

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

https://github.com/JOE1994 created https://github.com/llvm/llvm-project/pull/90625 First round of Sema checks were run at initial parsing step. Creating a new BinaryOperator instance (with the re-built LHS or RHS) will trigger another round of Sema checks, which can lead to duplicate