https://github.com/balazske closed
https://github.com/llvm/llvm-project/pull/71392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= ,
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/DonatNagyE approved this pull request.
LGTM, but let's wait a bit for other reviewers before merging.
https://github.com/llvm/llvm-project/pull/71392
_
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/71392
From e92bf72fc80bb6823996cb71cb811d238b304aaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Thu, 2 Nov 2023 18:12:32 +0100
Subject: [PATCH 1/3] [clang][analyzer] Improve 'errno' handli
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/71392
From e92bf72fc80bb6823996cb71cb811d238b304aaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Thu, 2 Nov 2023 18:12:32 +0100
Subject: [PATCH 1/2] [clang][analyzer] Improve 'errno' handli
@@ -80,3 +80,12 @@ int test_fileno_arg_note(FILE *f1) {
// expected-note{{The 1st argument to 'dup' is < 0 but should be >= 0}} \
// expected-note{{Assuming that 'fileno' fails}}
}
+
+int test_readlink_bufsize_zero(char *Buf, size_t Bufsize) {
DonatNagyE wr
@@ -1418,31 +1423,42 @@ void StdLibraryFunctionsChecker::checkPostCall(const
CallEvent &Call,
return "";
});
Pred = C.addTransition(NewState, Pred, Tag);
- } else {
-const NoteTag *Tag =
-C.getNoteTag([Note, RV](PathSe
@@ -622,9 +624,8 @@ class StdLibraryFunctionsChecker
Call.getOriginExpr());
}
-const NoteTag *describe(CheckerContext &C,
-StringRef FunctionName) const override {
- return errno_mod
@@ -1392,15 +1393,19 @@ void StdLibraryFunctionsChecker::checkPostCall(const
CallEvent &Call,
// Still add these note tags, the other checker should add only its
// specialized note tags. These general note tags are handled always by
// StdLibraryFunctionsChecker.
https://github.com/DonatNagyE commented:
This is a good change, I like that you merged the two note tags into one with a
"smart" lambda.
I have some minor suggestions and I think it'd be useful to see some open
source results; but after that this could be a good improvement.
https://github.co
https://github.com/DonatNagyE edited
https://github.com/llvm/llvm-project/pull/71392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
@llvm/pr-subscribers-clang
Author: Balázs Kéri (balazske)
Changes
The checker now displays one combined note tag for errno-related and
"case"-related notes. Previous functions in the errno-modeling part that were
used for constr
https://github.com/balazske created
https://github.com/llvm/llvm-project/pull/71392
The checker now displays one combined note tag for errno-related and
"case"-related notes. Previous functions in the errno-modeling part that were
used for construction of note tags are removed. The note tag ad
12 matches
Mail list logo
