https://github.com/balazske closed
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske reopened
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske closed
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
balazske wrote:
@haoNoQ Could you check if this change is OK to merge?
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/66207
From 5b9ad350fedad88a4d2ac93bafc29bae893c32e7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Wed, 13 Sep 2023 14:56:18 +0200
Subject: [PATCH 1/2] [clang][analyzer] Move checker
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
+Check for calls of standard library
@@ -532,6 +532,27 @@ def MismatchedDeallocatorChecker :
Checker<"MismatchedDeallocator">,
Dependencies<[DynamicMemoryModeling]>,
Documentation;
+def StdCLibraryFunctionsChecker : Checker<"StdCLibraryFunctions">,
+ HelpText<"Check for invalid arguments of C standard
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
+Check for calls of standard library
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
+Check for calls of standard library
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
steakhal wrote:
Align this
@@ -2651,100 +2745,6 @@ For a more detailed description of configuration
options, please see the
alpha.unix
^^^
steakhal wrote:
As we are here, could you align this with its section title as well?
https://github.com/llvm/llvm-project/pull/66207
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
+Check for calls of standard library
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
+Check for calls of standard library
https://github.com/steakhal approved this pull request.
I didn't spent much time on this, but I think it should be good.
Please check the docs with Grammarly to catch mistakes.
Also, please generate the HTML for the rst to verify how it looks.
I'm not sure if the release docs mentions this, but
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DonatNagyE approved this pull request.
Based on these clean test results I'd say that it's safe to move this checker
out of alpha.
@haoNoQ @steakhal Do you have any objections?
https://github.com/llvm/llvm-project/pull/66207
___
DonatNagyE wrote:
I tested this commit on several open-source projects, comparing it and its
parent with a configuration that enables the non-alpha checkers (so
StdCLibraryFunctions becomes enabled when this commit moves it out of alpha).
The results show that this checker doesn't produce
https://github.com/DonatNagyE edited
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
+Check for calls of standard library
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C
string functions:
return strlen(0); // warn
}
+.. _unix-StdCLibraryFunctions:
+
+unix.StdCLibraryFunctions (C)
+"""
+Check for calls of standard library
https://github.com/DonatNagyE commented:
(I started to nitpick the documentation text before I realized that it's just
old content moved in from elsewhere. Probably it's better to handle these in a
separate commit.)
https://github.com/llvm/llvm-project/pull/66207
https://github.com/balazske review_requested
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/balazske review_requested
https://github.com/llvm/llvm-project/pull/66207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
23 matches
Mail list logo
