[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

martinboehme wrote: Reverting: Causes build bots to fail because `TerminatorVisitor::StmtToEnv` is now unused. https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

@@ -489,6 +482,31 @@ transferCFGBlock(const CFGBlock , AnalysisContext , } AC.Log.recordState(State); } + + // If we have a terminator, evaluate its condition. + // This `Expr` may not appear as a `CFGElement` anywhere else, and it's + // important that we

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

https://github.com/Xazax-hun approved this pull request. Once @ymand's comment is resolved, it looks good to me. Thanks! https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

@@ -489,6 +482,31 @@ transferCFGBlock(const CFGBlock , AnalysisContext , } AC.Log.recordState(State); } + + // If we have a terminator, evaluate its condition. + // This `Expr` may not appear as a `CFGElement` anywhere else, and it's + // important that we

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/77750 >From 74ad27d843947e17d1cce38bee5a1bff2d9045f7 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Thu, 11 Jan 2024 10:47:41 + Subject: [PATCH] [clang][dataflow] Process terminator condition within

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cc21aa1922b3d0c4fde52046d8d16d1048f8064e 732a0b343b24eee4bb5f17e4c2edbe7268aa8955 --

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes In particular, it's important that we create the "fallback" atomic at this point (which we produce if the transfer function didn't produce a value for the expression) so that it is placed in the correct

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/77750 In particular, it's important that we create the "fallback" atomic at this point (which we produce if the transfer function didn't produce a value for the expression) so that it is placed in the correct