[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/65691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/65691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/65691: >From 6b8c1ee1507fbc143752fac966e4aabb36699e53 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 1 Sep 2023 13:01:24 -0700 Subject: [PATCH] [clang][deps] Generate command-lines lazily --- .../Dependen

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -136,9 +138,15 @@ struct ModuleDeps { /// determined that the differences are benign for this compilation. std::vector ClangModuleDeps; - /// Compiler invocation that can be used to build this module. Does not - /// include argv[0]. - std::vector BuildArguments; + /

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -136,9 +138,15 @@ struct ModuleDeps { /// determined that the differences are benign for this compilation. std::vector ClangModuleDeps; - /// Compiler invocation that can be used to build this module. Does not - /// include argv[0]. - std::vector BuildArguments; + /

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -136,9 +138,15 @@ struct ModuleDeps { /// determined that the differences are benign for this compilation. std::vector ClangModuleDeps; - /// Compiler invocation that can be used to build this module. Does not - /// include argv[0]. - std::vector BuildArguments; + /

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
@@ -532,7 +539,8 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module *M) { // Finish the compiler invocation. Requires dependencies and the context hash. MDC.addOutputPaths(CI, MD); - MD.BuildArguments = CI.getCC1CommandLine(); + MD.BuildInvocationOrArguments =

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Ben Langmuir via cfe-commits
@@ -532,7 +539,8 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module *M) { // Finish the compiler invocation. Requires dependencies and the context hash. MDC.addOutputPaths(CI, MD); - MD.BuildArguments = CI.getCC1CommandLine(); + MD.BuildInvocationOrArguments =

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/65691: This patch makes the generation of command lines for modular dependencies lazy/on-demand. That operation is somewhat expensive and prior to this patch used to be performed multiple times for the identical

[clang] [clang][deps] Generate command lines lazily (PR #65691)

2023-09-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 review_requested https://github.com/llvm/llvm-project/pull/65691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits