ilovepi wrote:
hmm, it does weirdly seem to be working now. Thanks for taking a look.
@mysterymath you're about the only person I know w/ much knowledge about
debuginfod testing, can you take a look when you get time? It seems like this
could be a flake. If it turns out to be, lets file an i
jansvoboda11 wrote:
> Hi, we're seeing a test failure in our x64 linux CI. This was the only commit
> in the blame. Can you take a look and revert if it will take a while to fix?
>
> Failing test: LLVM :: tools/llvm-debuginfod-find/cache.test
>
> Bot:
> https://ci.chromium.org/ui/p/fuchsia/bu
ilovepi wrote:
Hi, we're seeing a test failure in our x64 linux CI. This was the only commit
in the blame. Can you take a look and revert if it will take a while to fix?
Failing test: LLVM :: tools/llvm-debuginfod-find/cache.test
Bot:
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/88800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea approved this pull request.
This solves the performance issue I was seeing on Windows with a C++ clang
database. Thanks again for doing this @jansvoboda11!
https://github.com/llvm/llvm-project/pull/88800
___
cfe-commits maili
jansvoboda11 wrote:
@aganea Rebased, added tests and a prep-patch:
https://github.com/llvm/llvm-project/pull/102540.
https://github.com/llvm/llvm-project/pull/88800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/88800
>From e1aed43691bc02fe6d775c68908182289f2727c0 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Thu, 11 Apr 2024 14:44:55 -0700
Subject: [PATCH 1/2] [clang][deps] Only bypass scanning VFS for the module
cac
@@ -201,11 +201,8 @@ const CachedRealPath
&DependencyScanningFilesystemSharedCache::CacheShard::
return *StoredRealPath;
}
-static bool shouldCacheStatFailures(StringRef Filename) {
- StringRef Ext = llvm::sys::path::extension(Filename);
- if (Ext.empty())
-return fal
aganea wrote:
Ping @jansvoboda11! Just checking if you had time to finish this PR, to then
possibly integrate it into 19.x.
https://github.com/llvm/llvm-project/pull/88800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
jansvoboda11 wrote:
I don't think I'll have time to work on this PR in the short-term.
https://github.com/llvm/llvm-project/pull/88800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aganea wrote:
Ping @jansvoboda11! Are you able to get back to this soon? LG generally, just
missing a test case above. Thanks!
https://github.com/llvm/llvm-project/pull/88800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
@@ -201,11 +201,8 @@ const CachedRealPath
&DependencyScanningFilesystemSharedCache::CacheShard::
return *StoredRealPath;
}
-static bool shouldCacheStatFailures(StringRef Filename) {
- StringRef Ext = llvm::sys::path::extension(Filename);
- if (Ext.empty())
-return fal
@@ -201,11 +201,8 @@ const CachedRealPath
&DependencyScanningFilesystemSharedCache::CacheShard::
return *StoredRealPath;
}
-static bool shouldCacheStatFailures(StringRef Filename) {
- StringRef Ext = llvm::sys::path::extension(Filename);
- if (Ext.empty())
-return fal
@@ -362,7 +357,7 @@ DependencyScanningWorkerFilesystem::openFileForRead(const
Twine &Path) {
SmallString<256> OwnedFilename;
StringRef Filename = Path.toStringRef(OwnedFilename);
- if (Filename.ends_with(".pcm"))
+ if (shouldBypass(Filename))
jansvoboda
@@ -201,11 +201,8 @@ const CachedRealPath
&DependencyScanningFilesystemSharedCache::CacheShard::
return *StoredRealPath;
}
-static bool shouldCacheStatFailures(StringRef Filename) {
- StringRef Ext = llvm::sys::path::extension(Filename);
- if (Ext.empty())
-return fal
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -201,11 +201,8 @@ const CachedRealPath
&DependencyScanningFilesystemSharedCache::CacheShard::
return *StoredRealPath;
}
-static bool shouldCacheStatFailures(StringRef Filename) {
- StringRef Ext = llvm::sys::path::extension(Filename);
- if (Ext.empty())
-return fal
@@ -362,7 +357,7 @@ DependencyScanningWorkerFilesystem::openFileForRead(const
Twine &Path) {
SmallString<256> OwnedFilename;
StringRef Filename = Path.toStringRef(OwnedFilename);
- if (Filename.ends_with(".pcm"))
+ if (shouldBypass(Filename))
aganea wro
@@ -174,3 +174,30 @@ TEST(DependencyScanningFilesystem, CacheStatOnExists) {
EXPECT_EQ(InstrumentingFS->NumStatusCalls, 2u);
EXPECT_EQ(InstrumentingFS->NumExistsCalls, 0u);
}
+
+TEST(DependencyScanningFilesystem, CacheStatFailures) {
+ auto InMemoryFS = llvm::makeIntrusive
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
The scanning VFS doesn't cache stat failures of paths with no extension. This
was originally implemented to avoid caching the non-existence of the modules
cache directory that the modular scanner will ev
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/88800
The scanning VFS doesn't cache stat failures of paths with no extension. This
was originally implemented to avoid caching the non-existence of the modules
cache directory that the modular scanner will event
21 matches
Mail list logo
