https://github.com/Xazax-hun closed
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Xazax-hun wrote:
It has been a couple of days without any activity. I plan to merge this PR
tomorrow and address any potential concerns in a followup PR. Let me know if
you want me to wait a bit more if there are any concerns that should be
addressed first.
Xazax-hun wrote:
@MaskRay Thanks for the review. Do you think this is good to go or is there
anything else you want me to change?
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Xazax-hun updated
https://github.com/llvm/llvm-project/pull/98325
From 200d0b7ab622012fb8e74fcc40df6ba3be6bc215 Mon Sep 17 00:00:00 2001
From: Gabor Horvath
Date: Mon, 8 Jul 2024 11:18:02 +0100
Subject: [PATCH] [clang][driver] Fix --print-libgcc-file-name on Darwin
@@ -0,0 +1,27 @@
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=armv7em-apple-darwin \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-HARD_STATIC %s
+// CHECK-CLANGRT-HARD_STATIC:
@@ -0,0 +1,27 @@
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=armv7em-apple-darwin \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-HARD_STATIC %s
+// CHECK-CLANGRT-HARD_STATIC:
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
The patch LGTM, but I'd like actual Clang folks to stamp this.
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,97 @@
+// Test the output of -print-libgcc-file-name on Darwin.
ldionne wrote:
Ack. I think it's reasonable not to try to fix everything in one go since it
seems really involved. However, my thinking is more that the Darwin driver is
the odd one out
@@ -2230,6 +2239,7 @@ bool Driver::HandleImmediateArgs(const Compilation ) {
}
if (C.getArgs().hasArg(options::OPT_print_runtime_dir)) {
+initDarwinTarget();
Xazax-hun wrote:
I removed this change for now because I think we should probably fix this
https://github.com/Xazax-hun updated
https://github.com/llvm/llvm-project/pull/98325
From 9f3c99e278193af99d6a8928612f517be95aa6a6 Mon Sep 17 00:00:00 2001
From: Gabor Horvath
Date: Mon, 8 Jul 2024 11:18:02 +0100
Subject: [PATCH] Fix --print-libgcc-file-name on Darwin platforms
On Darwin,
@@ -1303,18 +1288,55 @@ void MachO::AddLinkRuntimeLib(const ArgList ,
ArgStringList ,
// rpaths. This is currently true from this place, but we need to be
// careful if this function is ever called before user's rpaths are emitted.
if (Opts & RLO_AddRPath) {
-
@@ -356,6 +363,12 @@ class LLVM_LIBRARY_VISIBILITY Darwin : public MachO {
void addProfileRTLibs(const llvm::opt::ArgList ,
llvm::opt::ArgStringList ) const override;
+ // Return the full path of the compiler-rt library on a Darwin MachO system.
+
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Gábor Horváth (Xazax-hun)
Changes
On Darwin, -print-libgcc-file-name was returning a nonsensical result. It would
return the name of the library that would be used by the default toolchain
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
15 matches
Mail list logo
