[clang] [clang][driver] Prevent clang picking the system headers/libraries when started via a symlink (PR #68091)

2023-10-04 Thread via cfe-commits
nolange wrote: > On the other hand; I agree that it's kinda implausible that this directory > would exist at all anywhere else than next to the actual executable. In that > case, perhaps those testcases are the only cases that would need to be > handled after all? If it exists this might caus

[clang] [clang][driver] Prevent clang picking the system headers/libraries when started via a symlink (PR #68091)

2023-10-04 Thread Liviu Ionescu via cfe-commits
ilg-ul wrote: > I wonder if this would need to be somewhat target specific. I took a first look, and it seems target specific. The strategy was to search for `InstalledDir` and see how it is used. It looks like in many places both locations are used, which means things are not that bad: ```c

[clang] [clang][driver] Prevent clang picking the system headers/libraries when started via a symlink (PR #68091)

2023-10-04 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > it's quite possible that someone has ended up depending on the previous de > > facto behaviour. > > Then we have to be super creative and find a better solution. > > How about changing the logic, and where `Driver.InstalledDir` is used, if the > desired file/folder is not

[clang] [clang][driver] Prevent clang picking the system headers/libraries when started via a symlink (PR #68091)

2023-10-04 Thread Liviu Ionescu via cfe-commits
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits