jrmwng wrote:
> @jrmwng PR #76985 (landed in
> [853b133](https://github.com/llvm/llvm-project/commit/853b13342a131e06d61293ec6e840642054c6c85))
> seems to have resolved this issue for me. Can you confirm that on your end?
Yes, your fix is effective
jansvoboda11 wrote:
@jrmwng PR #76985 (landed in 853b133) seems to have resolved this issue for me.
Can you confirm that on your end?
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jansvoboda11 wrote:
Thank you. I think the symlink is most likely the culprit. I'll be able to
confirm on my Windows machine tomorrow. For now, I have a speculative fix:
https://github.com/llvm/llvm-project/pull/76985
https://github.com/llvm/llvm-project/pull/74782
jrmwng wrote:
@jansvoboda11 the same error using the above steps
```
547>-- Build started: Project: check-all, Configuration: Release x64 --
547>Running all regression tests
547>llvm-lit.py: C:\GitHub\llvm-project\llvm\utils\lit\lit\llvm\config.py:46:
note: using lit tools: C:\Program
jrmwng wrote:
@jansvoboda11 it should be the following steps. (I try to repeat it now)
1. CMake (cmake-gui)
- Where is the source code: C:/GitHub/llvm-project/
- Where to build the binaries: C:/GitHub/llvm-project/build
- Click the "Configure" button
- Create Directory -->
jrmwng wrote:
@jansvoboda11 One thing is special.
The path ``C:\GitHub`` is a symbolic link to another harddisk.
```
GitHub [F:\GitHub]
```
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jansvoboda11 wrote:
> Thanks for reporting @jrmwng, I'll look into it.
I wasn't able to reproduce locally on Windows 10. Can you please share detailed
reproduction steps and any other config that may be relevant? It seems your
realpath to the LLVM repo is `"C:\GitHub\llvm-project"` and the
jansvoboda11 wrote:
Thanks for reporting @jrmwng, I'll look into it.
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrmwng wrote:
492>Failed Tests (1):
492> Clang :: Lexer/case-insensitive-include-absolute.c
I built with "clang", "X86" and "AArch64" under Windows 11 and VS2022 community
edition
```
492>-- Build started: Project: check-all, Configuration: Release x64 --
492>Running all regression
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jansvoboda11 wrote:
Ping.
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction
Preprocessor::HandleHeaderIncludeOrImport(
// The drive letter is optional for absolute paths on Windows, but
// clang currently cannot process absolute paths in #include lines that
// don't have a
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/74782
>From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Thu, 7 Dec 2023 15:15:16 -0800
Subject: [PATCH 1/6] [clang][lex] Fix non-portability diagnostics with
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction
Preprocessor::HandleHeaderIncludeOrImport(
// The drive letter is optional for absolute paths on Windows, but
// clang currently cannot process absolute paths in #include lines that
// don't have a
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/74782
>From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Thu, 7 Dec 2023 15:15:16 -0800
Subject: [PATCH 1/5] [clang][lex] Fix non-portability diagnostics with
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction
Preprocessor::HandleHeaderIncludeOrImport(
// The drive letter is optional for absolute paths on Windows, but
// clang currently cannot process absolute paths in #include lines that
// don't have a
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction
Preprocessor::HandleHeaderIncludeOrImport(
// The drive letter is optional for absolute paths on Windows, but
// clang currently cannot process absolute paths in #include lines that
// don't have a
jansvoboda11 wrote:
My first version of the test put backslashes into the source file (i.e.
`#include "C:\foo\bar"`) which doesn't really work, because Clang treats those
as string escape sequences. Instead of trying to replace `\` with `\\` in the
test, I chose to use forward slashes, which
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/74782
>From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Thu, 7 Dec 2023 15:15:16 -0800
Subject: [PATCH 1/4] [clang][lex] Fix non-portability diagnostics with
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/74782
>From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Thu, 7 Dec 2023 15:15:16 -0800
Subject: [PATCH 1/3] [clang][lex] Fix non-portability diagnostics with
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/74782
>From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Thu, 7 Dec 2023 15:15:16 -0800
Subject: [PATCH 1/2] [clang][lex] Fix non-portability diagnostics with
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction
Preprocessor::HandleHeaderIncludeOrImport(
// The drive letter is optional for absolute paths on Windows, but
// clang currently cannot process absolute paths in #include lines that
// don't have a
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction
Preprocessor::HandleHeaderIncludeOrImport(
// The drive letter is optional for absolute paths on Windows, but
// clang currently cannot process absolute paths in #include lines that
// don't have a
https://github.com/cachemeifyoucan approved this pull request.
LGTM with small comments.
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/74782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/74782
>From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Thu, 7 Dec 2023 15:15:16 -0800
Subject: [PATCH] [clang][lex] Fix non-portability diagnostics with absolute
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
The existing code incorrectly assumes that `Path` can be empty. It can't, it
always contains at least `` or `"`. On Unix, this patch fixes an incorrect
diagnostics that instead of `"/Users/blah"`
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/74782
The existing code incorrectly assumes that `Path` can be empty. It can't, it
always contains at least `<` or `"`. On Unix, this patch fixes an incorrect
diagnostics that instead of `"/Users/blah"`
29 matches
Mail list logo
