@@ -0,0 +1,25 @@
+// Test that autolink hints for frameworks don't use the private module name.
jansvoboda11 wrote:
Why is this desired? What happens if the private module name is provided?
https://github.com/llvm/llvm-project/pull/77120
@@ -984,7 +984,9 @@ static void inferFrameworkLink(Module *Mod) {
assert(!Mod->isSubFramework() &&
"Can only infer linking for top-level frameworks");
- Mod->LinkLibraries.push_back(Module::LinkLibrary(Mod->Name,
+ StringRef FrameworkName(Mod->Name);
+ FrameworkN
@@ -0,0 +1,25 @@
+// Test that autolink hints for frameworks don't use the private module name.
ributzka wrote:
The auto-link hint is supposed to provide a framework name, which is incorrect
when you pass the name of the private module. The linker ignores invali
@@ -984,7 +984,9 @@ static void inferFrameworkLink(Module *Mod) {
assert(!Mod->isSubFramework() &&
"Can only infer linking for top-level frameworks");
- Mod->LinkLibraries.push_back(Module::LinkLibrary(Mod->Name,
+ StringRef FrameworkName(Mod->Name);
+ FrameworkN
@@ -984,7 +984,9 @@ static void inferFrameworkLink(Module *Mod) {
assert(!Mod->isSubFramework() &&
"Can only infer linking for top-level frameworks");
- Mod->LinkLibraries.push_back(Module::LinkLibrary(Mod->Name,
+ StringRef FrameworkName(Mod->Name);
+ FrameworkN
@@ -0,0 +1,25 @@
+// Test that autolink hints for frameworks don't use the private module name.
jansvoboda11 wrote:
Makes sense, thanks!
https://github.com/llvm/llvm-project/pull/77120
___
cfe-commits mailing list
cfe-
https://github.com/jansvoboda11 approved this pull request.
https://github.com/llvm/llvm-project/pull/77120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ributzka wrote:
Thanks for the review Jan.
https://github.com/llvm/llvm-project/pull/77120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ributzka closed
https://github.com/llvm/llvm-project/pull/77120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ributzka created
https://github.com/llvm/llvm-project/pull/77120
- [clang][modules] Remove no longer needed autolink test for TBD files.
- [clang][modules] Remove `_Private` suffix from framework auto-link hints.
>From 166bc82a6bd7fa2dff6fb405aadcf6c2a9d48f51 Mon Sep 17 00:0
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Juergen Ributzka (ributzka)
Changes
- [clang][modules] Remove no longer needed autolink test for TBD files.
- [clang][modules] Remove `_Private` suffix from framework auto-link hints.
---
Full diff: https://github.com/llvm/llvm-pr
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Juergen Ributzka (ributzka)
Changes
- [clang][modules] Remove no longer needed autolink test for TBD files.
- [clang][modules] Remove `_Private` suffix from framework auto-link hints.
---
Full diff: https://github.com/llvm/llvm-project/pu
12 matches
Mail list logo
