[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-10-02 Thread Tobias Hieta via cfe-commits
tru wrote: Yeah i noticed when I got further down in my notification stack :) https://github.com/llvm/llvm-project/pull/67891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-10-02 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Did you plan to backport this as well @mstorsjo ? Yes, I did - in #64464, with https://github.com/llvm/llvm-project-release-prs/pull/716 (where tests failed after cherrypicking; looking into that test issue right now). https://github.com/llvm/llvm-project/pull/67891

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-10-02 Thread Tobias Hieta via cfe-commits
tru wrote: Did you plan to backport this as well @mstorsjo ? https://github.com/llvm/llvm-project/pull/67891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-10-01 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/67891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-10-01 Thread via cfe-commits
https://github.com/alvinhochun approved this pull request. Thanks, looks good to me codewise. I haven't tested it myself but I trust that you have. This seems worth backporting to 17.x since it technically fixes a new regression. https://github.com/llvm/llvm-project/pull/67891

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-09-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-platform-windows Changes Prior to 591c4b64b3650884c2c68eb47d755ebb62981b99, the mingw specific linker options -mthreads, -mconsole, -mwindows and -mdll would be tolerated also at compile time, but generating a warning about being unused. After that

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-09-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/67891 From da64c467a35cf544df5346b512746715ffc3db32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sun, 1 Oct 2023 00:29:21 +0300 Subject: [PATCH] [clang] [MinGW] Tolerate mingw specific

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-09-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/67891 Prior to 591c4b64b3650884c2c68eb47d755ebb62981b99, the mingw specific linker options -mthreads, -mconsole, -mwindows and -mdll would be tolerated also at compile time, but generating a warning about being