github-actions[bot] wrote:
@vvd170501 Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/81364
>From f73060f7f09a747c90fa559641abd8c72f4ee66f Mon Sep 17 00:00:00 2001
From: vvd170501 <36827317+vvd170...@users.noreply.github.com>
Date: Sat, 10 Feb 2024 19:19:52 +0300
Subject: [PATCH 1/8] Add
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5dc9e87c8cae7842edcaa4dd01308873109208da
fa70ace81c2311636ce369259aded2b8f40ad0d6 --
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/81364
>From f73060f7f09a747c90fa559641abd8c72f4ee66f Mon Sep 17 00:00:00 2001
From: vvd170501 <36827317+vvd170...@users.noreply.github.com>
Date: Sat, 10 Feb 2024 19:19:52 +0300
Subject: [PATCH 1/7] Add
@@ -2363,8 +2356,11 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
+ // This check is disabled for designated
https://github.com/vvd170501 edited
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2363,8 +2356,11 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
+ // This check is disabled for designated
@@ -2363,8 +2356,11 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
+ // This check is disabled for designated
https://github.com/vvd170501 edited
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2363,8 +2356,11 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
+ // This check is disabled for designated
@@ -2363,8 +2356,11 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
+ // This check is disabled for designated
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/81364
>From f73060f7f09a747c90fa559641abd8c72f4ee66f Mon Sep 17 00:00:00 2001
From: vvd170501 <36827317+vvd170...@users.noreply.github.com>
Date: Sat, 10 Feb 2024 19:19:52 +0300
Subject: [PATCH 1/6] Add
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/81364
>From f73060f7f09a747c90fa559641abd8c72f4ee66f Mon Sep 17 00:00:00 2001
From: vvd170501 <36827317+vvd170...@users.noreply.github.com>
Date: Sat, 10 Feb 2024 19:19:52 +0300
Subject: [PATCH 1/5] Add
@@ -2363,8 +2356,11 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
+ // This check is disabled for designated
@@ -2363,8 +2356,11 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
+ // This check is disabled for designated
https://github.com/AaronBallman approved this pull request.
Changes mostly LGTM aside from some minor nits.
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -148,6 +148,10 @@ Non-comprehensive list of changes in this release
New Compiler Flags
--
+- ``-Wmissing-designated-field-initializers``, grouped under
``-Wmissing-designated-field-initializers``.
+ This diagnostic can be disabled to make
@@ -120,6 +120,10 @@ Non-comprehensive list of changes in this release
New Compiler Flags
--
+- ``-Wmissing-designated-field-initializers``, grouped under
``-Wmissing-designated-field-initializers``.
AaronBallman wrote:
```suggestion
-
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -120,6 +120,10 @@ Non-comprehensive list of changes in this release
New Compiler Flags
--
+- ``-Wmissing-designated-field-initializers``, grouped under
``-Wmissing-designated-field-initializers``.
AaronBallman wrote:
I think it would be
vvd170501 wrote:
Ping
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/81364
>From f73060f7f09a747c90fa559641abd8c72f4ee66f Mon Sep 17 00:00:00 2001
From: vvd170501 <36827317+vvd170...@users.noreply.github.com>
Date: Sat, 10 Feb 2024 19:19:52 +0300
Subject: [PATCH 1/4] Add
@@ -120,6 +120,10 @@ Non-comprehensive list of changes in this release
New Compiler Flags
--
+- ``-Wmissing-designated-field-initializers``, grouped under
``-Wmissing-designated-field-initializers``.
shafik wrote:
CC @AaronBallman
@@ -120,6 +120,10 @@ Non-comprehensive list of changes in this release
New Compiler Flags
--
+- ``-Wmissing-designated-field-initializers``, grouped under
``-Wmissing-designated-field-initializers``.
vvd170501 wrote:
Would it be ok to also
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/81364
>From 9701011a9c88397cf3bb2c089e7295f62c7e13fe Mon Sep 17 00:00:00 2001
From: vvd170501 <36827317+vvd170...@users.noreply.github.com>
Date: Sat, 10 Feb 2024 19:19:52 +0300
Subject: [PATCH 1/4] Add
@@ -2363,23 +2356,32 @@ void InitListChecker::CheckStructUnionTypes(
}
// Emit warnings for missing struct field initializers.
- if (!VerifyOnly && InitializedSomething && CheckForMissingFields &&
- !RD->isUnion()) {
-// It is possible we have one or more
@@ -6165,6 +6165,10 @@ def ext_initializer_string_for_char_array_too_long :
ExtWarn<
def warn_missing_field_initializers : Warning<
"missing field %0 initializer">,
InGroup, DefaultIgnore;
+// The same warning, but another group is needed to disable it separately.
+def
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Thank you for this improvement! Please add a release note to
`clang/docs/ReleaseNotes.rst` so users know about the new diagnostic group.
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits
https://github.com/vvd170501 edited
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vadim D. (vvd170501)
Changes
Fixes #68933.
#56628 changed the behavior of `-Wmissing-field-initializers`, which
introduces many new warnings in C++ code that uses partial designated
initializers. If such code is being built with
https://github.com/vvd170501 ready_for_review
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 edited
https://github.com/llvm/llvm-project/pull/81364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/81364
>From b7e3ffb25e1a50ac29e50ac8536ea93244f219a1 Mon Sep 17 00:00:00 2001
From: vvd170501 <36827317+vvd170...@users.noreply.github.com>
Date: Sat, 10 Feb 2024 19:19:52 +0300
Subject: [PATCH] Add
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/vvd170501 created
https://github.com/llvm/llvm-project/pull/81364
Fixes #68933.
>From aa48713c9bf23c24bbc0c22dd67f332ca970d2b8 Mon Sep 17 00:00:00 2001
From: Vadim Dudkin
Date: Sat, 10 Feb 2024 02:29:48 +0300
Subject: [PATCH] Add -Wmissing-designated-field-initializers,
38 matches
Mail list logo
