[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-06 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: https://github.com/llvm/llvm-project/pull/84017 changed the test in ways that this isn't needed anymore. https://github.com/llvm/llvm-project/pull/84008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-06 Thread Jonas Hahnfeld via cfe-commits
https://github.com/hahnjo closed https://github.com/llvm/llvm-project/pull/84008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Ok, but that still doesn't change the fact that the Clang driver will search > for a system-wide CUDA installation unless passed `--cuda-path`... We also do this with the GCC toolchain, the issue is whether or not there's an error if it didn't find it. Doing `clang -v` will al

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: Ok, but that still doesn't change the fact that the Clang driver will search for a system-wide CUDA installation unless passed `--cuda-path`... https://github.com/llvm/llvm-project/pull/84008 ___ cfe-commits mailing list cfe-commits@list

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Found it https://github.com/llvm/llvm-project/pull/84017. https://github.com/llvm/llvm-project/pull/84008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > The invocations in `clang/test/Driver/cuda-omp-unsupported-debug-options.cu` > don't pass `-emit-llvm` but `-###`. > > ``` > > cat /dev/null | ./bin/clang -### -x cuda - -nogpulib -nogpuinc -c && echo > $? > ``` > > should error with recent CUDA installations because of `sm_

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: > > > Might need `-nogpulib -nogpuinc` in those cases, we do that in other > > > `.cu` files in the test suite. > > > > > > No, I already tried that, it doesn't work for me. All > > `clang/test/Driver/*.cu` that supply `-nocudainc` also pass `--cuda-path`... > > The only reason

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: In any case, it's not really important and this works. I'm mostly just curious why it doesn't seem to work as I would expect since there might be something to fix. https://github.com/llvm/llvm-project/pull/84008 ___ cfe-commits mailing

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > Might need `-nogpulib -nogpuinc` in those cases, we do that in other `.cu` > > files in the test suite. > > No, I already tried that, it doesn't work for me. All > `clang/test/Driver/*.cu` that supply `-nocudainc` also pass `--cuda-path`... The only reason it will fail with

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: > > It definitely doesn't work for the "pure" CUDA invocations, it still finds > > my local installation and complains. It might work for the OpenMP > > invocations, but hard to tell for me on a system with CUDA installed. As > > it's a `.cu` test after all, I think I would prefe

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > It definitely doesn't work for the "pure" CUDA invocations, it still finds my > local installation and complains. It might work for the OpenMP invocations, > but hard to tell for me on a system with CUDA installed. As it's a `.cu` test > after all, I think I would prefer the u

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: > We had a lot that were like this previously. Guessing this one slipped > through because of the `zlib` requirement. I actually think there are some more left; for example `clang/test/Driver/cuda-dwarf-2.cu` has many `not %clang` invocations that don't specify `--cuda-path`. Th

[clang] [clang] Add cuda-path arguments to failing test (PR #84008)

2024-03-05 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: We had a lot that were like this previously. Guessing this one slipped through because of the `zlib` requirement. Does this work with `-nogpulib` instead? Usually easier than passing the dummy CUDA path. https://github.com/llvm/llvm-project/pull/84008