[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/86943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread Haojian Wu via cfe-commits
@@ -1356,6 +1356,8 @@ NormalizedConstraint::fromConstraintExpr(Sema , NamedDecl *D, const Expr *E) { S, CSE->getExprLoc(), Sema::InstantiatingTemplate::ConstraintNormalization{}, D, CSE->getSourceRange()); + if (Inst.isInvalid()) +

[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/86943 >From cb863750a7c57e76bbb8d63cc88975f5adaa65aa Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 28 Mar 2024 13:23:51 +0100 Subject: [PATCH 1/2] [clang] Add invalid check in

[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. There’s a typo, but LGTM otherwise. https://github.com/llvm/llvm-project/pull/86943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread via cfe-commits
@@ -1356,6 +1356,8 @@ NormalizedConstraint::fromConstraintExpr(Sema , NamedDecl *D, const Expr *E) { S, CSE->getExprLoc(), Sema::InstantiatingTemplate::ConstraintNormalization{}, D, CSE->getSourceRange()); + if (Inst.isInvalid()) +

[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/86943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes This is an oversight spot in #86869, we should always check the invalid bit after constructing the `Sema::InstantiatingTemplate` RAII object. --- Full diff: https://github.com/llvm/llvm-project/pull/86943.diff

[clang] [clang] Add invalid check in NormalizedConstraint::fromConstraintExpr. (PR #86943)

2024-03-28 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/86943 This is an oversight spot in #86869, we should always check the invalid bit after constructing the `Sema::InstantiatingTemplate` RAII object. >From cb863750a7c57e76bbb8d63cc88975f5adaa65aa Mon Sep 17 00:00:00