https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I guess buildkite/github-pull-requests is stuck
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
@jfbastien @fhahn @efriedma-quic I'd like to merge if no other feedback
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/vitalybuka approved this pull request.
LGTM, but please wait others feedback
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vitalybuka wrote:
As we discussed offline, it would nice to handle cases like this
```
struct Foo {
int x; // we should try to make sure X is initialized.
char buff[1024]; // this one is fine to skip
};
void main() {
Foo foo;
}
```
But seems moving size check deeper does not help.
@@ -0,0 +1,60 @@
+// Pattern related max size tests: 1, 1024, 4096
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown
-ftrivial-auto-var-init=pattern -ftrivial-auto-var-init-max-size=1 %s
-emit-llvm -o - | FileCheck -check-prefix=PATTERN-COMMON
-check-prefix=PATTERN-MAX-1 %s
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1205,10 +1205,19 @@ static void emitStoresForConstant(CodeGenModule ,
const VarDecl ,
}
auto *SizeVal = llvm::ConstantInt::get(CGM.IntPtrTy, ConstantSize);
+ auto trivialAutoVarInitMaxSize =
vitalybuka wrote:
would it be simpler
```
if
https://github.com/haopliu edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl ,
Address Loc) {
auto trivialAutoVarInit =
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl ,
Address Loc) {
auto trivialAutoVarInit =
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl ,
Address Loc) {
auto trivialAutoVarInit =
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl ,
Address Loc) {
auto trivialAutoVarInit =
https://github.com/haopliu edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl ,
Address Loc) {
auto trivialAutoVarInit =
@@ -656,6 +656,13 @@ def
err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error<
def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error<
"'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">;
+def
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl ,
Address Loc) {
auto trivialAutoVarInit =
@@ -656,6 +656,13 @@ def
err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error<
def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error<
"'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">;
+def
@@ -656,6 +656,13 @@ def
err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error<
def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error<
"'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">;
+def
https://github.com/haopliu edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
20 matches
Mail list logo
