s-barannikov wrote:
We do use this option with gcc, this is why I filed the issue.
https://github.com/llvm/llvm-project/pull/69114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
Since `--entry` is wrong, `--entry=` is unsupported, and nobody seems to use
the driver option which only affects linking, we probably should just remove
it. Users are expected to use `-Wl,-e,entry` or `-Wl,--entry=entry` anyway.
https://github.com/llvm/llvm-project/pull/69114
JohnyTheCarrot wrote:
Heya @MaskRay
If and when you get the chance, would you mind giving it another look?
I applied your requested changes. :)
Thanks!
https://github.com/llvm/llvm-project/pull/69114
___
cfe-commits mailing list
JohnyTheCarrot wrote:
Ping.
https://github.com/llvm/llvm-project/pull/69114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JohnyTheCarrot updated
https://github.com/llvm/llvm-project/pull/69114
>From 111d19a7e03e2c59afc8d40c8210a901378594ee Mon Sep 17 00:00:00 2001
From: Tuur Martens
Date: Sun, 15 Oct 2023 18:08:35 +0200
Subject: [PATCH 1/3] [clang] Fix --entry command line option
---
@@ -5474,7 +5474,8 @@ def _dyld_prefix_EQ : Joined<["--"], "dyld-prefix=">;
def _dyld_prefix : Separate<["--"], "dyld-prefix">, Alias<_dyld_prefix_EQ>;
def _encoding_EQ : Joined<["--"], "encoding=">, Alias;
def _encoding : Separate<["--"], "encoding">, Alias;
-def _entry :
@@ -5474,7 +5474,8 @@ def _dyld_prefix_EQ : Joined<["--"], "dyld-prefix=">;
def _dyld_prefix : Separate<["--"], "dyld-prefix">, Alias<_dyld_prefix_EQ>;
def _encoding_EQ : Joined<["--"], "encoding=">, Alias;
def _encoding : Separate<["--"], "encoding">, Alias;
-def _entry :
JohnyTheCarrot wrote:
Ping. Requested changes were made. Apologies if this ping is misplaced, I made
it in good faith.
> (Please make sure to edit the description before merging so that git log does
> not contain irrelevant information.)
You mean during the merge phase, right?
https://github.com/JohnyTheCarrot updated
https://github.com/llvm/llvm-project/pull/69114
>From 111d19a7e03e2c59afc8d40c8210a901378594ee Mon Sep 17 00:00:00 2001
From: Tuur Martens
Date: Sun, 15 Oct 2023 18:08:35 +0200
Subject: [PATCH 1/2] [clang] Fix --entry command line option
---
@@ -0,0 +1,5 @@
+// RUN: %clang -### --entry test %s 2>&1 | FileCheck %s
MaskRay wrote:
In the absence of `--target=`, the default target triple
`LLVM_DEFAULT_TARGET_TRIPLE` is used. The selected `ToolChain` may not run
AddLinkerInputs to render `-e`.
We
https://github.com/MaskRay requested changes to this pull request.
The new option (alias) can be unnamed.
https://github.com/llvm/llvm-project/pull/69114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/s-barannikov approved this pull request.
Thanks, LGTM
(Please make sure to edit the description before merging so that `git log` does
not contain irrelevant information.)
https://github.com/llvm/llvm-project/pull/69114
___
https://github.com/JohnyTheCarrot updated
https://github.com/llvm/llvm-project/pull/69114
>From 111d19a7e03e2c59afc8d40c8210a901378594ee Mon Sep 17 00:00:00 2001
From: Tuur Martens
Date: Sun, 15 Oct 2023 18:08:35 +0200
Subject: [PATCH] [clang] Fix --entry command line option
---
https://github.com/JohnyTheCarrot created
https://github.com/llvm/llvm-project/pull/69114
New to this sort of thing, still learning how to work with the project.
Contructive feedback very welcome.
See [the corresponding
issue](https://github.com/llvm/llvm-project/issues/68355) for information
14 matches
Mail list logo
