[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread Fred Tingaud via cfe-commits
frederic-tingaud-sonarsource wrote: Yes please :) https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread via cfe-commits
cor3ntin wrote: Thanks! Do you need me to merge this for you? https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread Fred Tingaud via cfe-commits
https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/81776 >From c12b2e26ad7a114aff09b89c75178d4ab7890a20 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Wed, 14 Feb 2024 19:40:29 +0100 Subject: [PATCH 1/3] [clang] Fix isInStdNamespace for Decl

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread Fred Tingaud via cfe-commits
frederic-tingaud-sonarsource wrote: Oh, I didn't know about this, but it does look better. Thanks! https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread Fred Tingaud via cfe-commits
https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/81776 >From c12b2e26ad7a114aff09b89c75178d4ab7890a20 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Wed, 14 Feb 2024 19:40:29 +0100 Subject: [PATCH 1/3] [clang] Fix isInStdNamespace for Decl

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread via cfe-commits
cor3ntin wrote: Hum, should we use `getNonTransparentContext` instead? That would be cleaner https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread Fred Tingaud via cfe-commits
https://github.com/frederic-tingaud-sonarsource updated https://github.com/llvm/llvm-project/pull/81776 >From c12b2e26ad7a114aff09b89c75178d4ab7890a20 Mon Sep 17 00:00:00 2001 From: Fred Tingaud Date: Wed, 14 Feb 2024 19:40:29 +0100 Subject: [PATCH 1/2] [clang] Fix isInStdNamespace for Decl

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-15 Thread via cfe-commits
https://github.com/cor3ntin commented: Looks good. Can you add an entry to clang/docs/ReleseNotes.rst? There is an ast matchers section. Thanks https://github.com/llvm/llvm-project/pull/81776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fred Tingaud (frederic-tingaud-sonarsource) Changes The MSVC STL implementation declares multiple classes using: ```cpp namespace std { extern "C++" class locale { ... }; } ``` `isInStdNamespace` uses the first DeclContext to

[clang] [clang] Fix isInStdNamespace for Decl flagged extern c++ (PR #81776)

2024-02-14 Thread Fred Tingaud via cfe-commits
https://github.com/frederic-tingaud-sonarsource created https://github.com/llvm/llvm-project/pull/81776 The MSVC STL implementation declares multiple classes using: ```cpp namespace std { extern "C++" class locale { ... }; } ``` `isInStdNamespace` uses the first DeclContext to check