asavonic wrote:
Thanks a lot @jplehr and @DKLoehr for helping with reproducers, and @erichkeane
for taking care of the revert.
The compiler trips on `LinkageComputer::computeTypeLinkageInfo` for `case
Type::MemberPointer`, where only `CXXRecord` is expected, it seems.
We get a `FunctionProtoTy
DKLoehr wrote:
Here's what cvise gave me; unfortunately, I'm in a rush so I don't have time to
clean it up any further. It crashes when run with `clang++ repro.cc -std=c++20
-Wno-everyt hing -fsyntax-only -ferror-limit=0`
repro.cc:
```
template using conditional_t = _IfRes;
template void for
DKLoehr wrote:
I'm working on reducing my reproduction, but it's taking a while.
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jplehr wrote:
I can try later today to get dumps/preprocessed source or maybe some better
idea on how to reproduce the issue.
@jhuber6 if you have immediate thoughts on how to provide that (or maybe even
what may be the issue), let me know.
https://github.com/llvm/llvm-project/pull/136128
erichkeane wrote:
Revert submitted here: https://github.com/llvm/llvm-project/pull/136317
When CI is ok with it, I'll merge it.
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
erichkeane wrote:
Hmm... do either of you (@jplehr @DKLoehr ) have the ability to provide the
author a reduced example they can work with? We can revert in the meantime,
but without a reduction provided (or AT LEAST a pre-processed example), there
isn't anything we can really do about these r
DKLoehr wrote:
This is breaking builds when compiling chromium as well, bisected to this
change. Example build:
https://ci.chromium.org/ui/p/chromium/builders/ci/ToTLinux%20(dbg)/31974/overview.
Compiler output can be seen by clicking `[raw]` under the `compile` step, but
I'm working on a min
jplehr wrote:
I think this broke one of our bots:
https://lab.llvm.org/buildbot/#/builders/10/builds/3726/steps/10/logs/stdio
The bot was red for another issue at the time, but the stack trace includes
methods that are touched in this PR.
This is part of the stack trace:
```
#12 0x748dc31b
asavonic wrote:
Sure, I'll post another patch to update release notes.
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
I was going to say we need a release note but you have merged it :)
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asavonic wrote:
Thanks everyone for review!
Test issues were indeed fixed after rebase.
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/asavonic closed
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/asavonic ready_for_review
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov approved this pull request.
Thanks! LGTM as well.
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
FYI the libc++ CI has been fixed so all you need to do is to rebase your branch
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Fznamznon wrote:
> Libcxx tests failed. I'll check them tomorrow.
IMO they fail now in all PRs
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
erichkeane wrote:
This seems reasonable to me, but I'd like to see if @mizvekov has thoughts?
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/asavonic updated
https://github.com/llvm/llvm-project/pull/136128
>From 79a70bb55f864a14a7bc7d4ec99af44b86b801ba Mon Sep 17 00:00:00 2001
From: Andrew Savonichev
Date: Thu, 17 Apr 2025 20:18:52 +0900
Subject: [PATCH] [clang] Handle instantiated members to determine visibility
https://github.com/asavonic converted_to_draft
https://github.com/llvm/llvm-project/pull/136128
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asavonic wrote:
Libcxx tests failed. I'll check them tomorrow.
```
Failed Tests (15):
llvm-libc++-shared.cfg.in ::
libcxx/containers/views/mdspan/extents/assert.conversion.pass.cpp
llvm-libc++-shared.cfg.in ::
libcxx/containers/views/mdspan/extents/assert.ctor_from_array.pass.cpp
llvm-lib
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andrew Savonichev (asavonic)
Changes
As reported in issue #103477, visibility of instantiated member
functions used to be ignored when calculating visibility of a specialization.
This patch modifies `getLVForClassMember` to look up for a
https://github.com/asavonic created
https://github.com/llvm/llvm-project/pull/136128
As reported in issue #103477, visibility of instantiated member functions used
to be ignored when calculating visibility of a specialization.
This patch modifies `getLVForClassMember` to look up for a source t
23 matches
Mail list logo
