[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/88642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/88642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

@@ -997,6 +987,11 @@ class Sema final : public SemaBase { return *OpenACCPtr; } + SemaOpenMP &OpenMP() { +assert(OpenMPPtr); Endilll wrote: Done https://github.com/llvm/llvm-project/pull/88642 ___ cfe-co

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

@@ -997,6 +987,11 @@ class Sema final : public SemaBase { return *OpenACCPtr; } + SemaOpenMP &OpenMP() { Endilll wrote: This was discussed back when we started splitting `Sema` up: https://github.com/llvm/llvm-project/pull/84184#discussion_r1520027821

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

@@ -11,6 +11,7 @@ /// //===--===// +#include "clang/Sema/SemaOpenMP.h" Endilll wrote: Main module header goes first per our coding standard: https://llvm.org/docs/CodingStandards.html#inclu

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

@@ -997,6 +987,11 @@ class Sema final : public SemaBase { return *OpenACCPtr; } + SemaOpenMP &OpenMP() { +assert(OpenMPPtr); alexey-bataev wrote: Add assertion message https://github.com/llvm/llvm-project/pull/88642 ___

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

@@ -11,6 +11,7 @@ /// //===--===// +#include "clang/Sema/SemaOpenMP.h" alexey-bataev wrote: Sort it properly? https://github.com/llvm/llvm-project/pull/88642 ___

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

@@ -997,6 +987,11 @@ class Sema final : public SemaBase { return *OpenACCPtr; } + SemaOpenMP &OpenMP() { alexey-bataev wrote: ```suggestion SemaOpenMP &getOpenMP() { ``` https://github.com/llvm/llvm-project/pull/88642 __

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

Endilll wrote: I intentionally split formatting changes into a separate commit if reviewers want to look at changes without formatting noise. If, given the volume of changes here, there is an appetite to remove `OpenMP` and `OMP` from names inside `SemaOpenMP` right in this patch, I can do tha

[clang] [clang] Introduce `SemaOpenMP` (PR #88642)

llvmbot wrote: @llvm/pr-subscribers-openmp Author: Vlad Serebrennikov (Endilll) Changes This patch moves OpenMP-related entities out of `Sema` to a newly created `SemaOpenMP` class. This is a part of the effort to split `Sema` up, and follows the recent example of CUDA, OpenACC, SYCL, HL