kadircet wrote:
Do you or @petrhosek have some free cycles to follow up on that soon?
Because as things stand, unit test execution is currently in a very fragile
state. Anyone that adds a unittest to clang currently runs the risk of braking
something completely unrelated (I do agree that it's
rnk wrote:
> Would it make sense to have a custom main for AllClangUnitTests and register
> all targets, just like clang driver does?
That sounds reasonable.
I toyed with the idea of putting the registration into a static initializer,
but it raises the question of where you put it. Putting it
kadircet wrote:
hi folks, this change triggered some other failures in a distance, you can see
detailed analysis in
https://github.com/llvm/llvm-project/pull/143695#issuecomment-2970691063.
but tl;dr; LLVM shares some state throughout a process. This isn't something
new with this change, unit
tahonermann wrote:
I ended up spending a lot of time barking down the wrong rabbit hole due to
these changes. @rnk, please see
https://github.com/llvm/llvm-project/issues/140799.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailin
@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) {
.Case("kernel", llvm::CodeModel::Kernel)
.Case("medium", llvm::CodeModel::Medium)
.Case("large", llvm::CodeModel::Large)
-
rnk wrote:
I hacked together a workaround here:
https://github.com/llvm/llvm-project/pull/138613
I'm mostly just guessing remotely, since I don't have a reliable repro, that
the final PerformPending... event is rounding into the previous event group
that just ended. If the JSON encodes this n
AaronBallman wrote:
Yup, seeing this again on https://github.com/llvm/llvm-project/pull/132776
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
aeubanks wrote:
I've also seen ConstantEvaluationC99 intermittently fail on our mac bots
recently
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
dyung wrote:
I've been seeing intermittent failures of
AllClangUnitTests/TimeProfilerTest/ConstantEvaluationCxx20 and
AllClangUnitTests/TimeProfilerTest/ConstantEvaluationC99 on my MacOS bot, but I
haven't had a chance to try and figure out if it might be related to your
change or not.
Const
rnk wrote:
> FWIW, I'm seeing the test failure on Windows x64 with a debug build of
> Clang's unit tests as of a fresh fetch of main this morning.
Sorry about that! I leaned on the Windows premerge tests to find Windows issues
(they did, that was useful), but I'm pretty sure it uses release, n
AaronBallman wrote:
> @rnk see [#137577
> (comment)](https://github.com/llvm/llvm-project/pull/137577#issuecomment-2843963228)
> for some of the bots that got the assertion failure.
>
> > Update: Back to normal after
> > [afd738c](https://github.com/llvm/llvm-project/commit/afd738cd9016ddef4e
owenca wrote:
@rnk see
https://github.com/llvm/llvm-project/pull/137577#issuecomment-2843963228 for
some of the bots that got the assertion failure.
> Update: Back to normal after
> [afd738c](https://github.com/llvm/llvm-project/commit/afd738cd9016ddef4e26b309770ba35fd017a178).
I meant the
rnk wrote:
Are the `CodeGenTest.TestNonAlterTest` failures still an issue? I don't see
that failure on any bots. I haven't gotten any reports.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
rnk wrote:
> `BasicTests` and `FormatTests` had fairly few deps (they didn't need Sema
> etc) and compiled much fewer files than they presumably now do. Does it make
> sense to keep those as distinct binaries?
FormatTests has many clang dependencies, but after rebuilding, it looks like
it's s
@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) {
.Case("kernel", llvm::CodeModel::Kernel)
.Case("medium", llvm::CodeModel::Medium)
.Case("large", llvm::CodeModel::Large)
-
nico wrote:
`BasicTests` and `FormatTests` had fairly few deps (they didn't need Sema etc)
and compiled much fewer files than they presumably now do. Does it make sense
to keep those as distinct binaries?
https://github.com/llvm/llvm-project/pull/134196
rnk wrote:
I disabled the failing test in 743c32eb8195c248c699c61ffbac141947b8e6ab.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
I attempted to repro on my macbook, but it doesn't reproduce. This test doesn't
seem high value, and I thin kthe right next step is to disable it to green the
bots before debugging it.
https://github.com/llvm/llvm-project/pull/134196
___
c
dyung wrote:
> LLVM Buildbot has detected a new failure on builder
> `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang`
> at step 6 "test-build-unified-tree-check-all".
>
> Full details are available at:
> https://lab.llvm.org/buildbot/#/builders/190/builds/19202
>
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot4` while building
`clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/169/builds/10964
Here is the relevant piece
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-4` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/19202
Here is th
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk wrote:
If anyone is looking for stories about the value of premerge testing, I was all
set to push this tonight, but I saw the linux premerge test failure. I debugged
it, and it turns out to be a subtle interaction where if you run Clang codegen
with registered targets but no registered Ta
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/9] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/8] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/8] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) {
.Case("kernel", llvm::CodeModel::Kernel)
.Case("medium", llvm::CodeModel::Medium)
.Case("large", llvm::CodeModel::Large)
-
@@ -304,7 +304,7 @@ getCodeModel(const CodeGenOptions &CodeGenOpts) {
.Case("kernel", llvm::CodeModel::Kernel)
.Case("medium", llvm::CodeModel::Medium)
.Case("large", llvm::CodeModel::Large)
-
rnk wrote:
Ping, WDYT?
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/8] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
https://github.com/rnk ready_for_review
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/7] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang/lib/CodeGen/BackendUtil.cpp clang/unittests/Dri
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/6] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/5] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/4] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/3] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/134196
>From 528be44ebae8ea5cd7f23c51ad11c314a73f152b Mon Sep 17 00:00:00 2001
From: Reid Kleckner
Date: Fri, 28 Mar 2025 22:11:05 -0700
Subject: [PATCH 1/2] [clang] Merge gtest binaries into AllClangUnitTests
This reduces
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Reid Kleckner (rnk)
Changes
This reduces the size of the clang/unittests build directory by 64% and my
overall build dir size by 5%. Static linking is the real driving factor here,
but even if the default build configuration used shared l
https://github.com/rnk converted_to_draft
https://github.com/llvm/llvm-project/pull/134196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -77,3 +104,25 @@ add_subdirectory(Index)
add_subdirectory(InstallAPI)
add_subdirectory(Serialization)
add_subdirectory(Support)
+
+
+# If we're doing a single merged clang unit test binary, add that target after
+# all the previous subdirectories have been processed.
+get_pr
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Reid Kleckner (rnk)
Changes
This reduces the size of the clang/unittests build directory by 64% and my
overall build dir size by 5%. Static linking is the real driving factor here,
but even if the default build configuration used s
https://github.com/rnk created https://github.com/llvm/llvm-project/pull/134196
This reduces the size of the clang/unittests build directory by 64% and my
overall build dir size by 5%. Static linking is the real driving factor here,
but even if the default build configuration used shared librar
45 matches
Mail list logo
