wheatman wrote:
I'll change it from a assert to a diagnostic, my thought had been that it is
not a fault with the program, but an issue with the compiler so figured it
should be an assert.
In that case I assume it should be an error and not a warning since I don't
believe a correct program
shafik wrote:
Please make sure before you commit that you update the description with more
details. This is what will show up in the git log and we want to make sure that
is detailed enough to allow folks to debug build issues etc without having to
examine each commit in detail.
shafik wrote:
> Thanks for this PR! Emitting a diag in `TransformTemplateParmRefExpr` would
> probably a better way to go about it. It's not clear to me that the assert`
> is an improvement , and adding a diag would not be a lot more work. Would
> that be something you would be willing to
cor3ntin wrote:
Thanks for this PR!
Emitting a diag in `TransformTemplateParmRefExpr` would probably a better way
to go about it. It's not clear to me that the assert` is an improvement , and
adding a diag would not be a lot more work. Would that be something you would
be willing to explore?
wheatman wrote:
This is designed to detect bugs like
https://github.com/llvm/llvm-project/issues/71888 with an assert instead of
silently changing the meaning of the code.
an example of the code which the assert will trigger on is
```
#include
#include
template
constexpr auto static
https://github.com/wheatman updated
https://github.com/llvm/llvm-project/pull/74220
>From 86e187f7f13c5cbb0d1afb9ebbe9c0e7022269a6 Mon Sep 17 00:00:00 2001
From: Brian Wheatman
Date: Sat, 2 Dec 2023 22:17:24 -0500
Subject: [PATCH] [clang] assert fail when number of arguments in pack exceed
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 38f75d606f94e6b552fd74d487b061a1f8f907fa
8990877d381639d8498630fd4e9b30732ab893d6 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (wheatman)
Changes
…ation limit
---
Full diff: https://github.com/llvm/llvm-project/pull/74220.diff
1 Files Affected:
- (modified) clang/lib/AST/ExprCXX.cpp (+1)
``diff
diff --git a/clang/lib/AST/ExprCXX.cpp
https://github.com/wheatman created
https://github.com/llvm/llvm-project/pull/74220
…ation limit
>From 8990877d381639d8498630fd4e9b30732ab893d6 Mon Sep 17 00:00:00 2001
From: Brian Wheatman
Date: Sat, 2 Dec 2023 22:17:24 -0500
Subject: [PATCH] [clang] assert fail when number of arguments in
