[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

shafik wrote: > @cor3ntin @shafik Hi, I want to take charge of this issue and submit a PR for > the fix. I would open a new PR and reference this one in the summary for completeness. It looks like this one is not going to picked up by the author and so if you can take it over and finish it

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

l1nxy wrote: @cor3ntin @shafikHi, I want to take charge of this issue and submit a PR for the fix. https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

cor3ntin wrote: If @HerrCai0907 doesn't reply, we should take over @shafik @erichkeane @Endilll https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

zyn0217 wrote: Could you please explain why you're closing the PR? https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

LYP951018 wrote: This PR should also be able to fix https://github.com/llvm/llvm-project/issues/63972. https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [llvm] [clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

@@ -19706,22 +19706,29 @@ static void buildLambdaCaptureFixit(Sema , LambdaScopeInfo *LSI, } } +static DeclContext *ignoreReuquiresBodyDecl(DeclContext *DC) { erichkeane wrote: Name here doesn't match what you're doing here. Perhaps something closer to

[llvm] [clang-tools-extra] [clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

HerrCai0907 wrote: ping @erichkeane @cor3ntin https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

HerrCai0907 wrote: > Thanks for the patch! > > Requires Expressions should be in an unevaluated context, so we should never > try to capture variables they mentioned. > > Maybe we need to test the evaluation context in either `tryCaptureVariable` > or `NeedToCaptureVariable`, rather than a

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/78598 >From 8fa3dc43e770025308da47f6aff309fa58c47fc3 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 18 Jan 2024 23:12:23 +0800 Subject: [PATCH 1/3] [clang] reject to capture variable in

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e611a4cf8060bf0a95b4acd9e136733425da085a a99f16ff51702ff249cdf8a47de0cf24a08f694a --

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/78598 >From 8fa3dc43e770025308da47f6aff309fa58c47fc3 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 18 Jan 2024 23:12:23 +0800 Subject: [PATCH 1/2] [clang] reject to capture variable in

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

zyn0217 wrote: I think this also fixes https://github.com/llvm/llvm-project/issues/63845 and the example in https://github.com/llvm/llvm-project/issues/41751#issuecomment-1696389046. https://github.com/llvm/llvm-project/pull/78598 ___ cfe-commits

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

cor3ntin wrote: Thanks for the patch! Requires Expressions should be in an unevaluated context, so we should never try to capture variables they mentioned. Maybe we need to test the evaluation context in either `tryCaptureVariable` or `NeedToCaptureVariable`, rather than a specific handling

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes Expression in `RequiresExprBodyDecl` is resolved as constants and should not be captured. Fixes: #69307, #76593. --- Full diff: https://github.com/llvm/llvm-project/pull/78598.diff 2 Files Affected:

[clang] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/78598 Expression in `RequiresExprBodyDecl` is resolved as constants and should not be captured. Fixes: #69307, #76593. >From 33db497c31fd9da3a3acfc0d419dcdc396752863 Mon Sep 17 00:00:00 2001 From: Congcong Cai