github-actions[bot] wrote:
@lolloz98 Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/90255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
Bot is unreliable, so copy-pasting:
> ⚠️ We detected that you are using a GitHub private e-mail address to
> contribute to the repo.
Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account.
See [LLVM
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lolloz98 updated
https://github.com/llvm/llvm-project/pull/90255
>From 0d473873057b094c8cf112f7075c4a578e54a4f5 Mon Sep 17 00:00:00 2001
From: lolloz98
Date: Fri, 26 Apr 2024 20:31:32 +0100
Subject: [PATCH 1/3] [clang] solve crash due to function overloading.
---
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -emit-llvm < %s
lolloz98 wrote:
Yes. I gave another read now and found out the FileCheck guide to solve some of
my doubts.
I will need to double check also the llvm IR generation, if everything is ok, I
should be able to
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -emit-llvm < %s
efriedma-quic wrote:
Have you seen https://llvm.org/docs/TestingGuide.html#regression-test-structure
?
If you have any ideas for improving the documentation, please let me know (or
better, propose a patch;
https://github.com/lolloz98 updated
https://github.com/llvm/llvm-project/pull/90255
>From 0d473873057b094c8cf112f7075c4a578e54a4f5 Mon Sep 17 00:00:00 2001
From: lolloz98
Date: Fri, 26 Apr 2024 20:31:32 +0100
Subject: [PATCH 1/2] [clang] solve crash due to function overloading.
---
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -emit-llvm < %s
lolloz98 wrote:
Hello, I apologize, but could I ask some pointers to some docs for creating
tests for llvm? I didn't find any very good resource about it :)
https://github.com/llvm/llvm-project/pull/90255
@@ -5702,13 +5702,16 @@ CodeGenModule::getLLVMLinkageVarDefinition(const
VarDecl *VD) {
static void replaceUsesOfNonProtoConstant(llvm::Constant *old,
llvm::Function *newFn) {
// Fast path.
- if (old->use_empty()) return;
+ if
@@ -0,0 +1,7 @@
+// RUN: %clang_cc1 -emit-llvm < %s
efriedma-quic wrote:
Can you integrate this test into some existing file that's testing something
similar?
Please leave the bug number in a comment: something like `//GH88917`.
Please use FileCheck CHECK
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: None (lolloz98)
Changes
Closes #88917
I am a newby in llvm development.
I followed the suggestion for solving the issue. I added just a simple test to
verify that the compilation does not crash.
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/lolloz98 created
https://github.com/llvm/llvm-project/pull/90255
Closes #88917
I am a newby in llvm development.
I followed the suggestion for solving the issue. I added just a simple test to
verify that the compilation does not crash.
Should the test not be good enough
14 matches
Mail list logo
